Add test for incompatible gRPC argument/return values

semlanik · Jul 22, 2020 · d4f112f · d4f112f
1 parent 9a2cb79
commit d4f112f
Show file tree

Hide file tree

Showing 5 changed files with 41 additions and 0 deletions.
diff --git a/tests/test_grpc/clienttest.cpp b/tests/test_grpc/clienttest.cpp
@@ -604,3 +604,14 @@ TEST_F(ClientTest, MultipleSubscriptionsCancelTest)
     ASSERT_TRUE(isFinished);
     ASSERT_TRUE(isFinishedNext);
 }
+
+TEST_F(ClientTest, NonCompatibleArgRetTest)
+{
+    TestServiceClient testClient;
+    testClient.attachChannel(std::make_shared<QGrpcHttp2Channel>(m_echoServerAddress, QGrpcInsecureChannelCredentials() | QGrpcInsecureCallCredentials()));
+    SimpleIntMessage request(2048);
+    QPointer<SimpleStringMessage> result(new SimpleStringMessage);
+    ASSERT_TRUE(testClient.testMethodNonCompatibleArgRet(request, result) == QGrpcStatus::Ok);
+    ASSERT_STREQ(result->testFieldString().toStdString().c_str(), "2048");
+    delete result;
+}
diff --git a/tests/test_grpc/echoserver/main.cpp b/tests/test_grpc/echoserver/main.cpp
@@ -63,6 +63,14 @@ class SimpleTestImpl final : public qtprotobufnamespace::tests::TestService::Ser
     {
         return ::grpc::Status(::grpc::StatusCode::UNIMPLEMENTED, request->testfieldstring());
     }
+
+    ::grpc::Status testMethodNonCompatibleArgRet(grpc::ServerContext *, const qtprotobufnamespace::tests::SimpleIntMessage *request, qtprotobufnamespace::tests::SimpleStringMessage *response) override
+    {
+        std::cerr << "testMethodNonCompatibleArgRet called" << std::endl << request->testfield() << std::endl;
+        response->set_testfieldstring(std::to_string(request->testfield()));
+        return ::grpc::Status();
+    }
+
 };
 
 int main(int, char *[])

diff --git a/tests/test_grpc/proto/simpletest.proto b/tests/test_grpc/proto/simpletest.proto
@@ -6,6 +6,10 @@ message SimpleStringMessage {
     string testFieldString = 6;
 }
 
+message SimpleIntMessage {
+    sint32 testField= 1;
+}
+
 message BlobMessage {
     bytes testBytes = 1;
 }
diff --git a/tests/test_grpc/proto/testservice.proto b/tests/test_grpc/proto/testservice.proto
@@ -11,4 +11,5 @@ service TestService {
   rpc testMethodBiStream(stream SimpleStringMessage) returns (stream SimpleStringMessage) {}
   rpc testMethodBlobServerStream(BlobMessage) returns (stream BlobMessage) {}
   rpc testMethodStatusMessage(SimpleStringMessage) returns (SimpleStringMessage) {}
+  rpc testMethodNonCompatibleArgRet(SimpleIntMessage) returns (SimpleStringMessage) {}
 } 
diff --git a/tests/test_grpc_qml/qml/tst_grpc.qml b/tests/test_grpc_qml/qml/tst_grpc.qml
@@ -37,6 +37,11 @@ TestCase {
         testFieldString: "Test string"
     }
 
+    SimpleIntMessage {
+        id: intMsg
+        testField: 1024
+    }
+
     GrpcSubscription {
         id: serverStreamSubscription
         property bool ok: true
@@ -153,4 +158,16 @@ TestCase {
         compare(serverStreamInvalidSubscription.ok, true, "Subscription data failed")
         compare(serverStreamInvalidSubscription.enabled, false, "Subscription data failed")
     }
+
+    function test_nonCompatibleArgRet() {
+        var called = false;
+        var errorCalled = false;
+        TestServiceClient.testMethodNonCompatibleArgRet(intMsg, function(result) {
+            called = result.testFieldString === "1024";
+        }, function(status) {
+            errorCalled = true
+        })
+        wait(300)
+        compare(called && !errorCalled, true, "testMethodNonCompatibleArgRet was not called proper way")
+    }
 }