condition change to support password reset #5053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajshekar Chavakula <rchavakula.ctr@sumologic.com>
Signed-off-by: Rajshekar Chavakula <rchavakula.ctr@sumologic.com>
|
Don't forget the changelog entry :) |
Signed-off-by: Rajshekar Chavakula <rchavakula.ctr@sumologic.com>
echlebek
requested changes
Mar 7, 2024
Comment on lines
96
to
102
| // Change the resource to LocalSelfUserResource if a user tries to change | ||
| // its own password | ||
| if attrs.Verb == "update" && vars["subresource"] == "password" { | ||
| // check if request comes from webui | ||
| if strings.Contains(r.URL.Path, "/change_password") { | ||
| attrs.Resource = types.LocalSelfUserResource | ||
| } | ||
|
|
||
| switch vars["subresource"] { | ||
| case "password": |
There was a problem hiding this comment.
This code should work in terms of the RBAC system only, and not rely on inspecting URL fragments.
Signed-off-by: Rajshekar Chavakula <rchavakula.ctr@sumologic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
This change allows web UI users to update password by themselves.
Why is this change necessary?
feature request in ticket https://github.com/sensu/sensu-enterprise-go/issues/2631
Does your change need a Changelog entry?
requires entry to changelog, api documentation
Do you need clarification on anything?
Were there any complications while making this change?
Have you reviewed and updated the documentation for this change? Is new documentation required?
How did you verify this change?
Manual testing done, attached recording.
Screen.Recording.2024-02-14.at.9.46.00.PM.mov
Is this change a patch?