Simplify initialization flow

ArduinoFirmware/sh-simple-focuser.ino/sh-simple-focuser.ino.ino

@@ -12,7 +12,6 @@ void setup() {
   Serial.begin(57600, SERIAL_8N1);
   Serial.setTimeout(100);
   while (!Serial);
-  Serial.println("INITIALIZED#");
 
   myStepper.setCurrentPosition(0);
 	myStepper.setMaxSpeed(200.0);
@@ -24,6 +23,7 @@ void loop() {
     String command = Serial.readStringUntil('#');
     String response = processCommand(command);
     Serial.println(response);
+    Serial.flush();
   }
 
   myStepper.runSpeedToPosition();

SHSimpleFocuser/SHSimpleFocuser/DeviceController.cs

@@ -28,9 +28,8 @@ public void Connect(String comPort)
             serialConnection.Parity = SerialParity.None;
             serialConnection.StopBits = SerialStopBits.One;
             serialConnection.DataBits = 8;
-            serialConnection.ReceiveTimeout = 10;
+            serialConnection.ReceiveTimeout = 2;
             serialConnection.Connected = true;
-            _ = ReadResponse();
             connected = CommandBool(Commands.Connect);
             if(!connected)
             {
@@ -106,22 +105,44 @@ private bool CommandBool(string command)
         /// <returns>Response returned by the device</returns>
         private string CommandString(string command)
         {
-            traceLogger.LogMessage("CommandString", "Sending command " + command);
-            //All commands from and to the arduino ends with #
-            serialConnection.Transmit(command + "#");
-            return ReadResponse();
+            for (int retries = 3; retries >= 0; retries--)
+            {
+                traceLogger.LogMessage("CommandString", "Sending command " + command);
+                //All commands from and to the arduino ends with #
+                serialConnection.Transmit(command + "#");
+                string response = ReadResponse();
+                if (response.Length > 0) {
+                    return response;
+                }
+                if (retries > 0)
+                {
+                    traceLogger.LogMessage("CommandString", "Empty response encountered. Retrying...");
+
+                }
+            }
+
+            traceLogger.LogMessage("CommandString", "Retry limit has reached!");
+            return "";
         }
 
         /// <summary>
         /// Read a response from the arduino and returns it
         /// </summary>
         private String ReadResponse()
         {
-            traceLogger.LogMessage("ReadResponse", "Reading response");
-            String response = serialConnection.ReceiveTerminated("#");
-            response = response.Replace("#", "").Replace("\r", "").Replace("\n", "");
-            traceLogger.LogMessage("ReadResponse", "Received response " + response);
-            return response;
+            try
+            {
+                traceLogger.LogMessage("ReadResponse", "Reading response");
+                String response = serialConnection.ReceiveTerminated("#");
+                response = response.Replace("#", "").Replace("\r", "").Replace("\n", "");
+                traceLogger.LogMessage("ReadResponse", "Received response " + response);
+                return response;
+            }
+            catch (Exception)
+            {
+                traceLogger.LogMessage("ReadResponse", "Port in use or timeout!");
+                return "";
+            }
         }
 
 

SHSimpleFocuser/SHSimpleFocuser/FocuserDriver.cs

@@ -696,7 +696,7 @@ internal string DetectCOMPort()
                         Speed = SerialSpeed.ps57600,
                         PortName = portName,
                         Connected = true,
-                        ReceiveTimeout = 1,
+                        ReceiveTimeout = 2,
                         Parity = SerialParity.None,
                         StopBits = SerialStopBits.One,
                         DataBits = 8
@@ -721,8 +721,6 @@ internal string DetectCOMPort()
                     string response = "";
                     try
                     {
-                        // Try to handle the INITIALIZED# message
-                        _ = serial.ReceiveTerminated(SEPARATOR);
                         serial.Transmit("P" + SEPARATOR);
                         response = serial.ReceiveTerminated(SEPARATOR).Trim().Replace("#", "").Replace("\r", "").Replace("\n", "");
                     }

SHSimpleFocuser/SHSimpleFocuser/SHSimpleFocuser.csproj

@@ -82,6 +82,7 @@
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|AnyCPU'">
     <PlatformTarget>AnyCPU</PlatformTarget>
     <OutputPath>bin\Debug\</OutputPath>
+    <RegisterForComInterop>true</RegisterForComInterop>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|AnyCPU'">
     <PlatformTarget>AnyCPU</PlatformTarget>