Skip to content
This repository has been archived by the owner on Sep 12, 2019. It is now read-only.

Removing Runtime Babel Dependency #35

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

PierreAndreis
Copy link
Contributor

I have update babel presets to the latest, removed all runtime babel dependency and republished it

I have also raised the requirements to node 6.

Reason is because most of the ES5/6 stuff are already supported by Node 6, there is no need for run time babel. It just makes the application slower with the addition of numerous boilerplates

@PierreAndreis PierreAndreis mentioned this pull request Apr 16, 2018
@seripap
Copy link
Owner

seripap commented Apr 18, 2018

Thanks, I'll have time this weekend to take a look and get back to you

@PierreAndreis
Copy link
Contributor Author

@seripap If this is a major change, I could also get this opportunity to work on others requested features such as #28 #10

@seripap
Copy link
Owner

seripap commented Apr 18, 2018

@PierreAndreis sure thing, feel free to tackle whatever you can assist with 👍

@seripap
Copy link
Owner

seripap commented Apr 24, 2018

Any updates on your side for more changes? I may actually re-work portions so that babel is removed entirely. A lot of things are supported natively these days and it doesn't make sense to babelify a server side library

@PierreAndreis
Copy link
Contributor Author

@seripap I haven't made any change so far, but I agree with you on removing babel completely.
Only babel exclusive that node doesn't support yet is import/export (which babel is compiling to require... so no difference)

@PierreAndreis
Copy link
Contributor Author

PierreAndreis commented Apr 24, 2018

I can work on some changes tonight.
Basically I want to get a .JSON() method for each class so we can get a json including getter/setter
which would fix #10

* Adding documentation to undocumented attributes

Hopefully these docs can help others who browse to this page and want to know what the various stats are and what they mean.  Not all meanings were clear to me from data I've inspected, so I'm leaving some unspecified.  Obviously anyone can come along later and propose a change to add info I didn't know how to add.

* Improving this PR based on help from PierreAndreis
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants