This repository has been archived by the owner on Sep 12, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Removing Runtime Babel Dependency #35
Open
PierreAndreis
wants to merge
12
commits into
seripap:master
Choose a base branch
from
PierreAndreis:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Thanks, I'll have time this weekend to take a look and get back to you |
@PierreAndreis sure thing, feel free to tackle whatever you can assist with 👍 |
Any updates on your side for more changes? I may actually re-work portions so that babel is removed entirely. A lot of things are supported natively these days and it doesn't make sense to babelify a server side library |
@seripap I haven't made any change so far, but I agree with you on removing babel completely. |
I can work on some changes tonight. |
* Adding documentation to undocumented attributes Hopefully these docs can help others who browse to this page and want to know what the various stats are and what they mean. Not all meanings were clear to me from data I've inspected, so I'm leaving some unspecified. Obviously anyone can come along later and propose a change to add info I didn't know how to add. * Improving this PR based on help from PierreAndreis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have update babel presets to the latest, removed all runtime babel dependency and republished it
I have also raised the requirements to node 6.
Reason is because most of the ES5/6 stuff are already supported by Node 6, there is no need for run time babel. It just makes the application slower with the addition of numerous boilerplates