Skip to content

Commit

Permalink
removed more references to serverless.env.yaml
Browse files Browse the repository at this point in the history
  • Loading branch information
eahefnawy committed Aug 22, 2016
1 parent 61d657d commit c629b49
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 40 deletions.
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -55,7 +55,7 @@ Run `serverless remove` to clean up this function from your account.
- **[Understanding Serverless and its configuration files](docs/understanding-serverless)**
- [Serverless services and functions](docs/understanding-serverless/services-and-functions.md)
- [serverless.yml](docs/understanding-serverless/serverless-yml.md)
- [serverless.env.yml](docs/understanding-serverless/serverless-env-yml.md)
- [serverless variables](docs/understanding-serverless/serverless-variables.md)
- **[How to build your Serverless services](docs/guide)**
- [Installing Serverless](docs/guide/installation.md)
- [Provider account setup](docs/guide/provider-account-setup.md)
Expand Down
15 changes: 0 additions & 15 deletions lib/plugins/aws/deploy/tests/createStack.js
Expand Up @@ -13,7 +13,6 @@ describe('createStack', () => {
let awsDeploy;

const tmpDirPath = path.join(os.tmpdir(), (new Date()).getTime().toString());
const serverlessEnvYmlPath = path.join(tmpDirPath, 'serverless.env.yml');
const serverlessYmlPath = path.join(tmpDirPath, 'serverless.yml');
const serverlessYml = {
service: 'first-service',
Expand All @@ -24,24 +23,10 @@ describe('createStack', () => {
},
},
};
const serverlessEnvYml = {
vars: {},
stages: {
dev: {
vars: {},
regions: {
'us-east-1': {
vars: {},
},
},
},
},
};

beforeEach(() => {
serverless = new Serverless();
serverless.utils.writeFileSync(serverlessYmlPath, serverlessYml);
serverless.utils.writeFileSync(serverlessEnvYmlPath, serverlessEnvYml);
serverless.config.servicePath = tmpDirPath;
const options = {
stage: 'dev',
Expand Down
15 changes: 0 additions & 15 deletions lib/plugins/aws/deploy/tests/updateStack.js
Expand Up @@ -13,20 +13,6 @@ describe('updateStack', () => {
let awsDeploy;

const tmpDirPath = path.join(os.tmpdir(), (new Date()).getTime().toString());
const serverlessEnvYmlPath = path.join(tmpDirPath, 'serverless.env.yml');
const serverlessEnvYml = {
vars: {},
stages: {
dev: {
vars: {},
regions: {
'us-east-1': {
vars: {},
},
},
},
},
};

beforeEach(() => {
serverless = new Serverless();
Expand All @@ -40,7 +26,6 @@ describe('updateStack', () => {
awsDeploy.bucketName = 'deployment-bucket';
serverless.service.service = `service-${(new Date()).getTime().toString()}`;
serverless.config.servicePath = tmpDirPath;
serverless.utils.writeFileSync(serverlessEnvYmlPath, serverlessEnvYml);
awsDeploy.serverless.cli = new serverless.classes.CLI();
});

Expand Down
2 changes: 1 addition & 1 deletion lib/plugins/package/README.md
Expand Up @@ -12,7 +12,7 @@ upon zipping the service. The resulting path to the artifact will be appended to
The services `include` and `exclude` arrays are considered during zipping. At first the `exclude` will be applied. After
that the `include` will be applied to ensure that previously excluded files and folders can be included again.

Serverless will automatically exclude `.git`, `.gitignore`, `serverless.yml`, `serverless.env.yml` and `.DS_Store`.
Serverless will automatically exclude `.git`, `.gitignore`, `serverless.yml`, and `.DS_Store`.

Servlerless will skip this step if the user has defined it's own artifact in the `service.package.artifact` property.

Expand Down
2 changes: 0 additions & 2 deletions lib/plugins/package/lib/zipService.js
Expand Up @@ -27,8 +27,6 @@ module.exports = {
'.DS_Store',
'serverless.yaml',
'serverless.yml',
'serverless.env.yaml',
'serverless.env.yml',
'.serverless',
]);

Expand Down
6 changes: 0 additions & 6 deletions lib/plugins/package/tests/zipService.js
Expand Up @@ -56,9 +56,6 @@ describe('#zipService()', () => {
// serverless.yml
const serverlessYmlFilePath = path.join(tmpDirPath, 'serverless.yml');
serverless.utils.writeFileSync(serverlessYmlFilePath, 'serverless.yml file content');
// serverless.env.yml
const serverlessEnvYmlFilePath = path.join(tmpDirPath, 'serverless.env.yml');
serverless.utils.writeFileSync(serverlessEnvYmlFilePath, 'serverless.env.yml file content');
// .git
const gitFilePath = path.join(path.join(tmpDirPath, '.git'), 'some-git-file');
serverless.utils.writeFileSync(gitFilePath, 'some-git-file content');
Expand Down Expand Up @@ -202,9 +199,6 @@ describe('#zipService()', () => {
expect(unzippedFileData['serverless.yml'])
.to.be.equal(undefined);

expect(unzippedFileData['serverless.env.yml'])
.to.be.equal(undefined);

expect(unzippedFileData['.git/some-git-file'])
.to.equal(undefined);
})
Expand Down

0 comments on commit c629b49

Please sign in to comment.