Convert tagName to uppercase ASCII per spec

http://dom.spec.whatwg.org/#dom-element-tagname
servo · Sep 3, 2013 · 02437f7 · 02437f7 · bors-servo · Sep 3, 2013
1 parent 7ea10ff
commit 02437f7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/components/script/dom/element.rs b/src/components/script/dom/element.rs
@@ -19,6 +19,7 @@ use js::jsapi::{JSContext, JSObject};
 use std::cell::Cell;
 use std::comm;
 use std::str::eq_slice;
+use std::ascii::StrAsciiExt;
 use std::FromStr;
 
 pub struct Element {
@@ -171,7 +172,7 @@ impl<'self> Element {
 
 impl Element {
     pub fn TagName(&self) -> DOMString {
-        str(self.tag_name.to_owned())
+        str(self.tag_name.to_owned().to_ascii_upper())
     }
 
     pub fn Id(&self) -> DOMString {

diff --git a/src/test/html/content/test_prototypes.html b/src/test/html/content/test_prototypes.html
@@ -3,6 +3,7 @@
   <script src="harness.js"></script>
 </head>
 <body>
+  <foo-á>foo</foo-á>
   <script src="test_prototypes.js"></script>
 </body>
 </html>
diff --git a/src/test/html/content/test_prototypes.js b/src/test/html/content/test_prototypes.js
@@ -4,4 +4,7 @@ is(window.document.documentElement instanceof HTMLElement, true);
 is(window.document.documentElement instanceof HTMLHtmlElement, true);
 is(window.document instanceof Document, true);
 is(window.document instanceof HTMLDocument, true);
-finish();
+is(window.document.documentElement.tagName, "HTML");
+is(window.document.getElementsByTagName('foo-á')[0] instanceof HTMLUnknownElement, true);
+is(window.document.getElementsByTagName('foo-á')[0].tagName, "FOO-á");
+finish();