Add error handling tests to xrRigidTransform_constructor

servo · Jul 18, 2019 · 1098454 · 1098454
1 parent dc1da02
commit 1098454
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 12 deletions.
diff --git a/tests/wpt/metadata/MANIFEST.json b/tests/wpt/metadata/MANIFEST.json
@@ -688053,7 +688053,7 @@
    "testharness"
   ],
   "webxr/xrRigidTransform_constructor.https.html": [
-   "6a54fff808d93ac4423364b9c8b9d528a7e520c0",
+   "ad25a7f67ab30126fc9706b525cd02ac6ba36a3e",
    "testharness"
   ],
   "webxr/xrRigidTransform_inverse.https.html": [

diff --git a/tests/wpt/metadata/webxr/xrRigidTransform_constructor.https.html.ini b/tests/wpt/metadata/webxr/xrRigidTransform_constructor.https.html.ini
diff --git a/tests/wpt/web-platform-tests/webxr/xrRigidTransform_constructor.https.html b/tests/wpt/web-platform-tests/webxr/xrRigidTransform_constructor.https.html
@@ -75,13 +75,6 @@
   checkDOMPoint(identity.position, 0.0, 0.0, 0.0, 1.0);
   checkDOMPoint(identity.orientation, 0.0, 0.0, 0.0, 1.0);
 
-  // test creating transform with quaternion of length 0
-  // constructor should not crash
-  let zeroLength = new XRRigidTransform(
-      createDOMPoint([1.0, 2.0, 3.0]),
-      createDOMPoint([0.0, 0.0, 0.0, 0.0]));
-  checkTransform(zeroLength);
-
   // create transform with only position specified
   transform = new XRRigidTransform(createDOMPoint([1.0, 2.0, 3.0]));
   checkTransform(transform);
@@ -102,6 +95,15 @@
       coordDict([1.1, 2.1, 3.1, 1.0]));
   checkTransform(transform);
 
+  assert_throws(new TypeError(), () => new XRRigidTransform(
+      coordDict([1.0, 2.0, 3.0, 0.5]),
+      coordDict([1.1, 2.1, 3.1, 1.0])
+  ), "Constructor should throw TypeError for non-1 position w values");
+
+  assert_throws("InvalidStateError", () => new XRRigidTransform(
+      coordDict([1.0, 2.0, 3.0, 1.0]),
+      coordDict([0, 0, 0, 0])
+  ), "Constructor should throw InvalidStateError for non-normalizeable orientation values");
   resolve();
 });