Skip to content

Commit

Permalink
Force infallible binding methods to return void.(fixes #1933)
Browse files Browse the repository at this point in the history
  • Loading branch information
lpy committed Mar 20, 2014
1 parent 6040271 commit 1abdd9c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/components/script/dom/bindings/codegen/CodegenRust.py
Expand Up @@ -2461,6 +2461,8 @@ def __init__(self, errorReport, arguments, argsPre, returnType,
call = CGWrapper(call, pre="result_fallible = ")
elif result is not None:
call = CGWrapper(call, pre="result = ")
else:
call = CGWrapper(call, pre="let _: () = ")

call = CGWrapper(call)
self.cgRoot.append(call)
Expand Down

5 comments on commit 1abdd9c

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging lpy/servo/issue1933 = 1abdd9c into auto

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lpy/servo/issue1933 = 1abdd9c merged ok, testing candidate = 2fb8c84

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 2fb8c84

Please sign in to comment.