Skip to content

Commit

Permalink
Auto merge of #12621 - jdm:sigabrt, r=emilio
Browse files Browse the repository at this point in the history
Attach more signals to the backtrace signal handler.

These changes should enable meaningful backtraces in more unusual situations where the program would otherwise exit almost silently.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12618 (github issue number if applicable).
- [X] These changes do not require tests because we can't verify the terminal output of the program in erroneous cases

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12621)
<!-- Reviewable:end -->
  • Loading branch information
bors-servo committed Jul 28, 2016
2 parents 3401361 + dda3349 commit 25f93b6
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 5 deletions.
5 changes: 4 additions & 1 deletion components/servo/main.rs
Expand Up @@ -70,7 +70,10 @@ fn install_crash_handler() {
}
}

signal!(Sig::SEGV, handler);
signal!(Sig::SEGV, handler); // handle segfaults
signal!(Sig::ILL, handler); // handle stack overflow and unsupported CPUs
signal!(Sig::IOT, handler); // handle double panics
signal!(Sig::BUS, handler); // handle invalid memory access
}

#[cfg(target_os = "android")]
Expand Down
@@ -1,6 +1,6 @@
[readPixelsBadArgs.html]
type: testharness
expected: CRASH
expected: TIMEOUT
[WebGL test #0: testReadPixels]
expected: FAIL

@@ -1,6 +1,6 @@
[read-pixels-pack-alignment.html]
type: testharness
expected: CRASH
expected: TIMEOUT
[WebGL test #3: successfullyParsed should be true (of type boolean). Was undefined (of type undefined).]
expected: FAIL

@@ -1,3 +1,3 @@
[draw-arrays-out-of-bounds.html]
type: testharness
expected: CRASH
expected: TIMEOUT
@@ -1,3 +1,3 @@
[draw-elements-out-of-bounds.html]
type: testharness
expected: CRASH
expected: TIMEOUT

0 comments on commit 25f93b6

Please sign in to comment.