Skip to content

Commit

Permalink
style: Consistently use top-right-bottom-left order for physical sides.
Browse files Browse the repository at this point in the history
Bug: 1454591
Reviewed-by: heycam
MozReview-Commit-ID: 6pLRSO8YNDI
  • Loading branch information
upsuper authored and emilio committed May 19, 2018
1 parent cb764be commit 4ab0e85
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion components/style/properties/data.py
Expand Up @@ -4,7 +4,7 @@

import re

PHYSICAL_SIDES = ["top", "left", "bottom", "right"]
PHYSICAL_SIDES = ["top", "right", "bottom", "left"]
LOGICAL_SIDES = ["block-start", "block-end", "inline-start", "inline-end"]
PHYSICAL_SIZES = ["width", "height"]
LOGICAL_SIZES = ["block-size", "inline-size"]
Expand Down
2 changes: 1 addition & 1 deletion components/style/properties/helpers.mako.rs
Expand Up @@ -759,7 +759,7 @@

<%def name="four_sides_shorthand(name, sub_property_pattern, parser_function,
needs_context=True, allow_quirks=False, **kwargs)">
<% sub_properties=' '.join(sub_property_pattern % side for side in ['top', 'right', 'bottom', 'left']) %>
<% sub_properties=' '.join(sub_property_pattern % side for side in PHYSICAL_SIDES) %>
<%call expr="self.shorthand(name, sub_properties=sub_properties, **kwargs)">
#[allow(unused_imports)]
use parser::Parse;
Expand Down

0 comments on commit 4ab0e85

Please sign in to comment.