Skip to content

Commit

Permalink
Auto merge of #17422 - BorisChiou:stylo/animation/stop_flood_lighting…
Browse files Browse the repository at this point in the history
…_colors, r=hiro

stylo: Bug 1369625 - Make stop-color, flood-color, lighting-color animatable.

This is an interdependent patch of Bug 1369625. We make stop-color, flood-color, and lighting-color animatable by using IntermediateRGBA as the animation value type, just like 'color'
attribute. On the Gecko-side, we enable/add the reftest of them and update WPT expectations for these properties.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1369625](https://bugzilla.mozilla.org/show_bug.cgi?id=1369625).
- [X] These changes do not require tests because we have tests already in Gekco.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17422)
<!-- Reviewable:end -->
  • Loading branch information
bors-servo committed Jun 20, 2017
2 parents 546c9db + 785ef82 commit 4d997f0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions components/style/properties/longhand/svg.mako.rs
Expand Up @@ -23,7 +23,7 @@ ${helpers.predefined_type(
"stop-color", "RGBAColor",
"RGBA::new(0, 0, 0, 255)",
products="gecko",
animation_value_type="none",
animation_value_type="IntermediateRGBA",
spec="https://www.w3.org/TR/SVGTiny12/painting.html#StopColorProperty")}

${helpers.predefined_type("stop-opacity", "Opacity", "1.0",
Expand All @@ -37,7 +37,7 @@ ${helpers.predefined_type(
"flood-color", "RGBAColor",
"RGBA::new(0, 0, 0, 255)",
products="gecko",
animation_value_type="none",
animation_value_type="IntermediateRGBA",
spec="https://www.w3.org/TR/SVG/filters.html#FloodColorProperty")}

${helpers.predefined_type("flood-opacity", "Opacity",
Expand All @@ -48,7 +48,7 @@ ${helpers.predefined_type(
"lighting-color", "RGBAColor",
"RGBA::new(255, 255, 255, 255)",
products="gecko",
animation_value_type="none",
animation_value_type="IntermediateRGBA",
spec="https://www.w3.org/TR/SVG/filters.html#LightingColorProperty")}

// CSS Masking Module Level 1
Expand Down

0 comments on commit 4d997f0

Please sign in to comment.