Skip to content

Commit

Permalink
Auto merge of #14479 - asajeffrey:script-htmliframeelement-more-debug…
Browse files Browse the repository at this point in the history
…ging, r=jdm

Added debugging to htmliframeelement.rs.

<!-- Please describe your changes on the following line: -->

Add some debugging to iframe elements.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because they're just used in debugging

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14479)
<!-- Reviewable:end -->
  • Loading branch information
bors-servo committed Dec 7, 2016
2 parents 900cb3b + 97ae51c commit 4e0638b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions components/script/dom/htmliframeelement.rs
Expand Up @@ -109,6 +109,7 @@ impl HTMLIFrameElement {
let old_pipeline_id = self.pipeline_id.get();
let new_pipeline_id = PipelineId::new();
self.pipeline_id.set(Some(new_pipeline_id));
debug!("Frame {} created pipeline {}.", self.frame_id, new_pipeline_id);
(old_pipeline_id, new_pipeline_id)
}

Expand Down Expand Up @@ -692,6 +693,7 @@ impl VirtualMethods for HTMLIFrameElement {
// iframe attributes for the "first time"."
if self.upcast::<Node>().is_in_doc_with_browsing_context() {
debug!("iframe {} bound to browsing context.", self.frame_id);
debug_assert!(tree_in_doc, "is_in_doc_with_bc, but not tree_in_doc");
self.create_nested_browsing_context();
self.process_the_iframe_attributes(ProcessingMode::FirstTime);
}
Expand All @@ -705,6 +707,7 @@ impl VirtualMethods for HTMLIFrameElement {

// https://html.spec.whatwg.org/multipage/#a-browsing-context-is-discarded
if let Some(pipeline_id) = self.pipeline_id.get() {
debug!("Unbinding pipeline {} from frame {}.", pipeline_id, self.frame_id);
let window = window_from_node(self);

// The only reason we're waiting for the iframe to be totally
Expand Down

0 comments on commit 4e0638b

Please sign in to comment.