Skip to content

Commit

Permalink
Auto merge of #15245 - andreastt:webdriver-caps, r=jdm
Browse files Browse the repository at this point in the history
Correct capabilities returned by WebDriver server

<!-- Please describe your changes on the following line: -->

These patches aligns Servo’s capabilities with those in the [WebDriver standard](https://w3c.github.io/webdriver/webdriver-spec.html). See each commit’s message for further information.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _Servo needs more work before it can pass WPT WebDriver tests_

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15245)
<!-- Reviewable:end -->
  • Loading branch information
bors-servo committed Jan 27, 2017
2 parents f141ede + e4abc81 commit 556a46f
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions components/webdriver_server/lib.rs
Expand Up @@ -303,9 +303,7 @@ impl Handler {
let mut capabilities = BTreeMap::new();
capabilities.insert("browserName".to_owned(), "servo".to_json());
capabilities.insert("browserVersion".to_owned(), "0.0.1".to_json());
capabilities.insert("acceptSslCerts".to_owned(), false.to_json());
capabilities.insert("takeScreenshot".to_owned(), true.to_json());
capabilities.insert("takeElementScreenshot".to_owned(), false.to_json());
capabilities.insert("acceptInsecureCerts".to_owned(), false.to_json());
let rv = Ok(WebDriverResponse::NewSession(
NewSessionResponse::new(
session.id.to_string(),
Expand Down

0 comments on commit 556a46f

Please sign in to comment.