Skip to content

Commit

Permalink
Auto merge of #19305 - asajeffrey:test-perf-os-and-arch-in-data, r=jdm
Browse files Browse the repository at this point in the history
Include OS and architecture in test-perf data

<!-- Please describe your changes on the following line: -->

Initially, we're just running test-perf on linux-nightly, but at some point we should run on other architectures.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because they're test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19305)
<!-- Reviewable:end -->
  • Loading branch information
bors-servo committed Nov 20, 2017
2 parents e67bb6c + a57ba2a commit 7217232
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
10 changes: 10 additions & 0 deletions etc/ci/performance/runner.py
Expand Up @@ -9,6 +9,7 @@
import itertools
import json
import os
import platform
import subprocess
from datetime import datetime
from functools import partial
Expand All @@ -17,6 +18,8 @@


DATE = datetime.now().strftime("%Y%m%d")
MACHINE = platform.machine()
SYSTEM = platform.system()


def load_manifest(filename):
Expand Down Expand Up @@ -144,6 +147,9 @@ def valid_timing(timing, url=None):
# able to identify failed tests (successful tests have time >=0).
def create_placeholder(testcase):
return {
"system": SYSTEM,
"machine": MACHINE,
"date": DATE,
"testcase": testcase,
"title": "",
"navigationStart": 0,
Expand Down Expand Up @@ -173,6 +179,8 @@ def create_placeholder(testcase):
# rather than the url.
def set_testcase(timing, testcase=None):
timing['testcase'] = testcase
timing['system'] = SYSTEM
timing['machine'] = MACHINE
timing['date'] = DATE
return timing

Expand Down Expand Up @@ -245,6 +253,8 @@ def save_result_json(results, filename, manifest, expected_runs, base):
def save_result_csv(results, filename, manifest, expected_runs, base):

fieldnames = [
'system',
'machine',
'date',
'testcase',
'title',
Expand Down
2 changes: 1 addition & 1 deletion etc/ci/performance/test_all.sh
Expand Up @@ -48,7 +48,7 @@ python3 -m http.server > /dev/null 2>&1 &
# MANIFEST="page_load_test/tp5n/20160509.manifest"
MANIFEST="page_load_test/test.manifest" # A manifest that excludes
# timeout test cases
PERF_FILE="output/perf-$(date +%s).csv"
PERF_FILE="output/perf-$(uname -s)-$(uname -m)-$(date +%s).csv"

echo "Running tests"
python3 runner.py ${engine} --runs 4 --timeout "${timeout}" --base "${base}" \
Expand Down

0 comments on commit 7217232

Please sign in to comment.