Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
We were removing the Window from TLS and thus destroying it after ter…
…minating the windowing system, which caused an error due to calling a glfw function when it was not inititalized.
- Loading branch information
8e669a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from metajack
at larsbergstrom@8e669a3
8e669a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging larsbergstrom/servo/shutdown_window_destruction = 8e669a3 into auto
8e669a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
larsbergstrom/servo/shutdown_window_destruction = 8e669a3 merged ok, testing candidate = 6d0066a
8e669a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/435
8e669a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from metajack
at larsbergstrom@8e669a3
8e669a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging larsbergstrom/servo/shutdown_window_destruction = 8e669a3 into auto
8e669a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
larsbergstrom/servo/shutdown_window_destruction = 8e669a3 merged ok, testing candidate = f274106
8e669a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/481
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/436
8e669a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = f274106