PutForward=href on window and document location

servo · May 4, 2018 · a1d1b18 · a1d1b18
1 parent a5a120f
commit a1d1b18
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 21 deletions.
diff --git a/components/script/dom/webidls/Document.webidl b/components/script/dom/webidls/Document.webidl
@@ -83,7 +83,7 @@ dictionary ElementCreationOptions {
 // [OverrideBuiltins]
 partial /*sealed*/ interface Document {
   // resource metadata management
-  [/*PutForwards=href, */Unforgeable]
+  [PutForwards=href, Unforgeable]
   readonly attribute Location? location;
   [SetterThrows] attribute DOMString domain;
   readonly attribute DOMString referrer;

diff --git a/components/script/dom/webidls/Window.webidl b/components/script/dom/webidls/Window.webidl
@@ -12,7 +12,7 @@
 
   attribute DOMString name;
 
-  [/*PutForwards=href, */Unforgeable] readonly attribute Location location;
+  [PutForwards=href, Unforgeable] readonly attribute Location location;
   readonly attribute History history;
   [Pref="dom.customelements.enabled"]
   readonly attribute CustomElementRegistry customElements;

diff --git a/...html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html.ini b/...html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html.ini
@@ -17,19 +17,3 @@
 
   [Set data URL frame location.protocol to http+x]
     expected: FAIL
-
-  [Set HTTP URL frame location.protocol to x]
-    expected: FAIL
-
-  [Set HTTP URL frame location.protocol to data]
-    expected: FAIL
-
-  [Set HTTP URL frame location.protocol to ftp]
-    expected: FAIL
-
-  [Set HTTP URL frame location.protocol to gopher]
-    expected: FAIL
-
-  [Set HTTP URL frame location.protocol to http+x]
-    expected: FAIL
-
diff --git a/tests/wpt/metadata/html/browsers/the-window-object/window-properties.https.html.ini b/tests/wpt/metadata/html/browsers/the-window-object/window-properties.https.html.ini
@@ -32,9 +32,6 @@
   [Window attribute: onmousewheel]
     expected: FAIL
 
-  [Window unforgeable attribute: location]
-    expected: FAIL
-
   [Window replaceable attribute: locationbar]
     expected: FAIL