Skip to content

Commit

Permalink
Replace NoViewportPercentage with a macro
Browse files Browse the repository at this point in the history
  • Loading branch information
canova authored and SimonSapin committed Feb 9, 2017
1 parent 9204f2a commit abc40f6
Show file tree
Hide file tree
Showing 19 changed files with 104 additions and 103 deletions.
4 changes: 2 additions & 2 deletions components/style/properties/helpers.mako.rs
Expand Up @@ -333,9 +333,9 @@
<%def name="single_keyword(name, values, vector=False, **kwargs)">
<%call expr="single_keyword_computed(name, values, vector, **kwargs)">
use values::computed::ComputedValueAsSpecified;
use values::NoViewportPercentage;
use values::HasViewportPercentage;
impl ComputedValueAsSpecified for SpecifiedValue {}
impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);
</%call>
</%def>

Expand Down
4 changes: 2 additions & 2 deletions components/style/properties/longhand/background.mako.rs
Expand Up @@ -16,8 +16,8 @@ ${helpers.predefined_type("background-color", "CSSColor",
has_uncacheable_values="${product == 'gecko'}">
use std::fmt;
use style_traits::ToCss;
use values::HasViewportPercentage;
use values::specified::Image;
use values::NoViewportPercentage;

pub mod computed_value {
use values::computed;
Expand All @@ -35,7 +35,7 @@ ${helpers.predefined_type("background-color", "CSSColor",
}
}

impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

#[derive(Debug, Clone, PartialEq)]
#[cfg_attr(feature = "servo", derive(HeapSizeOf))]
Expand Down
12 changes: 6 additions & 6 deletions components/style/properties/longhand/border.mako.rs
Expand Up @@ -87,10 +87,10 @@ ${helpers.single_keyword("-moz-float-edge", "content-box margin-box",
spec="https://drafts.csswg.org/css-backgrounds/#border-image-source">
use std::fmt;
use style_traits::ToCss;
use values::NoViewportPercentage;
use values::HasViewportPercentage;
use values::specified::Image;

impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

pub mod computed_value {
use values::computed;
Expand Down Expand Up @@ -279,9 +279,9 @@ ${helpers.single_keyword("-moz-float-edge", "content-box margin-box",
spec="https://drafts.csswg.org/css-backgrounds/#border-image-repeat">
use std::fmt;
use style_traits::ToCss;
use values::NoViewportPercentage;
use values::HasViewportPercentage;

impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

pub mod computed_value {
pub use super::RepeatKeyword;
Expand Down Expand Up @@ -557,10 +557,10 @@ ${helpers.single_keyword("-moz-float-edge", "content-box margin-box",
spec="https://drafts.csswg.org/css-backgrounds/#border-image-slice">
use std::fmt;
use style_traits::ToCss;
use values::NoViewportPercentage;
use values::HasViewportPercentage;
use values::specified::{Number, Percentage};

impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

pub mod computed_value {
use values::computed::Number;
Expand Down
40 changes: 20 additions & 20 deletions components/style/properties/longhand/box.mako.rs
Expand Up @@ -31,8 +31,8 @@
%>
use values::computed::ComputedValueAsSpecified;
use style_traits::ToCss;
use values::NoViewportPercentage;
impl NoViewportPercentage for SpecifiedValue {}
use values::HasViewportPercentage;
no_viewport_percentage!(SpecifiedValue);

pub mod computed_value {
pub use super::SpecifiedValue as T;
Expand Down Expand Up @@ -113,8 +113,8 @@ ${helpers.single_keyword("-moz-top-layer", "none top",
}
}

use values::NoViewportPercentage;
impl NoViewportPercentage for SpecifiedValue {}
use values::HasViewportPercentage;
no_viewport_percentage!(SpecifiedValue);
impl ToComputedValue for SpecifiedValue {
type ComputedValue = computed_value::T;

Expand Down Expand Up @@ -152,8 +152,8 @@ ${helpers.single_keyword("-moz-top-layer", "none top",
gecko_inexhaustive="True"
gecko_ffi_name="mFloat"
spec="https://drafts.csswg.org/css-box/#propdef-float">
use values::NoViewportPercentage;
impl NoViewportPercentage for SpecifiedValue {}
use values::HasViewportPercentage;
no_viewport_percentage!(SpecifiedValue);
impl ToComputedValue for SpecifiedValue {
type ComputedValue = computed_value::T;

Expand Down Expand Up @@ -194,8 +194,8 @@ ${helpers.single_keyword("-moz-top-layer", "none top",
gecko_enum_prefix="StyleClear"
gecko_ffi_name="mBreakType"
spec="https://www.w3.org/TR/CSS2/visuren.html#flow-control">
use values::NoViewportPercentage;
impl NoViewportPercentage for SpecifiedValue {}
use values::HasViewportPercentage;
no_viewport_percentage!(SpecifiedValue);
impl ToComputedValue for SpecifiedValue {
type ComputedValue = computed_value::T;

Expand Down Expand Up @@ -396,9 +396,9 @@ ${helpers.single_keyword("overflow-x", "visible hidden scroll auto",
use std::fmt;
use style_traits::ToCss;
use values::computed::ComputedValueAsSpecified;
use values::NoViewportPercentage;
use values::HasViewportPercentage;

impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

impl ToCss for SpecifiedValue {
fn to_css<W>(&self, dest: &mut W) -> fmt::Result where W: fmt::Write {
Expand Down Expand Up @@ -442,8 +442,8 @@ ${helpers.single_keyword("overflow-x", "visible hidden scroll auto",
use values::specified::Time;

pub use values::specified::Time as SpecifiedValue;
use values::NoViewportPercentage;
impl NoViewportPercentage for SpecifiedValue {}
use values::HasViewportPercentage;
no_viewport_percentage!(SpecifiedValue);

pub mod computed_value {
pub use values::computed::Time as T;
Expand Down Expand Up @@ -703,8 +703,8 @@ ${helpers.single_keyword("overflow-x", "visible hidden scroll auto",
}
}

use values::NoViewportPercentage;
impl NoViewportPercentage for SpecifiedValue {}
use values::HasViewportPercentage;
no_viewport_percentage!(SpecifiedValue);

#[inline]
pub fn get_initial_value() -> computed_value::T {
Expand Down Expand Up @@ -745,8 +745,8 @@ ${helpers.single_keyword("overflow-x", "visible hidden scroll auto",
SpecifiedValue::parse(input)
}

use values::NoViewportPercentage;
impl NoViewportPercentage for SpecifiedValue {}
use values::HasViewportPercentage;
no_viewport_percentage!(SpecifiedValue);

impl ComputedValueAsSpecified for SpecifiedValue { }
</%helpers:vector_longhand>
Expand All @@ -773,7 +773,7 @@ ${helpers.single_keyword("overflow-x", "visible hidden scroll auto",
use std::ops::Deref;
use style_traits::ToCss;
use values::computed::ComputedValueAsSpecified;
use values::NoViewportPercentage;
use values::HasViewportPercentage;

pub mod computed_value {
pub use super::SpecifiedValue as T;
Expand Down Expand Up @@ -805,7 +805,7 @@ ${helpers.single_keyword("overflow-x", "visible hidden scroll auto",
})
}
}
impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

pub fn parse(context: &ParserContext, input: &mut Parser) -> Result<SpecifiedValue,()> {
SpecifiedValue::parse(context, input)
Expand Down Expand Up @@ -847,7 +847,7 @@ ${helpers.single_keyword("overflow-x", "visible hidden scroll auto",
use std::fmt;
use style_traits::ToCss;
use values::computed::ComputedValueAsSpecified;
use values::NoViewportPercentage;
use values::HasViewportPercentage;

pub mod computed_value {
pub use super::SpecifiedValue as T;
Expand Down Expand Up @@ -885,7 +885,7 @@ ${helpers.single_keyword("overflow-x", "visible hidden scroll auto",
}
}

impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

#[inline]
pub fn get_initial_value() -> computed_value::T {
Expand Down
4 changes: 2 additions & 2 deletions components/style/properties/longhand/column.mako.rs
Expand Up @@ -22,9 +22,9 @@ ${helpers.predefined_type("column-width",
spec="https://drafts.csswg.org/css-multicol/#propdef-column-count">
use std::fmt;
use style_traits::ToCss;
use values::NoViewportPercentage;
use values::HasViewportPercentage;

impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

#[derive(Debug, Clone, Copy, PartialEq)]
#[cfg_attr(feature = "servo", derive(HeapSizeOf))]
Expand Down
8 changes: 4 additions & 4 deletions components/style/properties/longhand/counters.mako.rs
Expand Up @@ -10,15 +10,15 @@
use cssparser::Token;
use std::ascii::AsciiExt;
use values::computed::ComputedValueAsSpecified;
use values::NoViewportPercentage;
use values::HasViewportPercentage;

use super::list_style_type;

pub use self::computed_value::T as SpecifiedValue;
pub use self::computed_value::ContentItem;

impl ComputedValueAsSpecified for SpecifiedValue {}
impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

pub mod computed_value {
use super::super::list_style_type;
Expand Down Expand Up @@ -179,7 +179,7 @@
use std::fmt;
use style_traits::ToCss;
use super::content;
use values::NoViewportPercentage;
use values::HasViewportPercentage;
use values::computed::ComputedValueAsSpecified;

use cssparser::{Token, serialize_identifier};
Expand All @@ -199,7 +199,7 @@
}

impl ComputedValueAsSpecified for SpecifiedValue {}
impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

impl ToCss for SpecifiedValue {
fn to_css<W>(&self, dest: &mut W) -> fmt::Result where W: fmt::Write {
Expand Down
24 changes: 12 additions & 12 deletions components/style/properties/longhand/font.mako.rs
Expand Up @@ -11,12 +11,12 @@
<%helpers:longhand name="font-family" animatable="False" need_index="True"
spec="https://drafts.csswg.org/css-fonts/#propdef-font-family">
use self::computed_value::{FontFamily, FamilyName};
use values::NoViewportPercentage;
use values::HasViewportPercentage;
use values::computed::ComputedValueAsSpecified;
pub use self::computed_value::T as SpecifiedValue;

impl ComputedValueAsSpecified for SpecifiedValue {}
impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

pub mod computed_value {
use cssparser::CssStringWriter;
Expand Down Expand Up @@ -223,9 +223,9 @@ ${helpers.single_keyword("font-variant-caps",
spec="https://drafts.csswg.org/css-fonts/#propdef-font-weight">
use std::fmt;
use style_traits::ToCss;
use values::NoViewportPercentage;
use values::HasViewportPercentage;

impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

#[derive(Debug, Clone, PartialEq, Eq, Copy)]
#[cfg_attr(feature = "servo", derive(HeapSizeOf))]
Expand Down Expand Up @@ -458,12 +458,12 @@ ${helpers.single_keyword("font-variant-caps",

<%helpers:longhand products="gecko" name="font-size-adjust" animatable="True"
spec="https://drafts.csswg.org/css-fonts/#propdef-font-size-adjust">
use values::NoViewportPercentage;
use values::HasViewportPercentage;
use values::computed::ComputedValueAsSpecified;
use values::specified::Number;

impl ComputedValueAsSpecified for SpecifiedValue {}
impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

#[derive(Copy, Clone, Debug, PartialEq)]
#[cfg_attr(feature = "servo", derive(HeapSizeOf))]
Expand Down Expand Up @@ -520,11 +520,11 @@ ${helpers.single_keyword("font-variant-caps",
spec="https://drafts.csswg.org/css-fonts/#propdef-font-synthesis">
use std::fmt;
use style_traits::ToCss;
use values::NoViewportPercentage;
use values::HasViewportPercentage;
use values::computed::ComputedValueAsSpecified;

impl ComputedValueAsSpecified for SpecifiedValue {}
impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

pub mod computed_value {
pub use super::SpecifiedValue as T;
Expand Down Expand Up @@ -610,12 +610,12 @@ ${helpers.single_keyword("font-variant-position",
spec="https://drafts.csswg.org/css-fonts/#propdef-font-feature-settings">
use std::fmt;
use style_traits::ToCss;
use values::NoViewportPercentage;
use values::HasViewportPercentage;
use values::computed::ComputedValueAsSpecified;
pub use self::computed_value::T as SpecifiedValue;

impl ComputedValueAsSpecified for SpecifiedValue {}
impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

pub mod computed_value {
use cssparser::Parser;
Expand Down Expand Up @@ -719,12 +719,12 @@ ${helpers.single_keyword("font-variant-position",
// https://www.w3.org/TR/css-fonts-3/#propdef-font-language-override
<%helpers:longhand name="font-language-override" products="none" animatable="False" extra_prefixes="moz"
spec="https://drafts.csswg.org/css-fonts-3/#propdef-font-language-override">
use values::NoViewportPercentage;
use values::HasViewportPercentage;
use values::computed::ComputedValueAsSpecified;
pub use self::computed_value::T as SpecifiedValue;

impl ComputedValueAsSpecified for SpecifiedValue {}
impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

pub mod computed_value {
use std::fmt;
Expand Down
12 changes: 6 additions & 6 deletions components/style/properties/longhand/inherited_box.mako.rs
Expand Up @@ -35,8 +35,8 @@ ${helpers.single_keyword("direction", "ltr rtl", need_clone=True, animatable=Fal
animatable="False"
spec="https://drafts.csswg.org/css-writing-modes/#propdef-text-orientation"
>
use values::NoViewportPercentage;
impl NoViewportPercentage for SpecifiedValue {}
use values::HasViewportPercentage;
no_viewport_percentage!(SpecifiedValue);

impl ToComputedValue for SpecifiedValue {
type ComputedValue = computed_value::T;
Expand Down Expand Up @@ -91,8 +91,8 @@ ${helpers.single_keyword("image-rendering",
use style_traits::ToCss;
use values::specified::Angle;

use values::NoViewportPercentage;
impl NoViewportPercentage for SpecifiedValue {}
use values::HasViewportPercentage;
no_viewport_percentage!(SpecifiedValue);

use std::f32::consts::PI;
use values::CSSFloat;
Expand Down Expand Up @@ -225,9 +225,9 @@ ${helpers.single_keyword("image-rendering",
use std::fmt;
use style_traits::ToCss;
use values::computed::ComputedValueAsSpecified;
use values::NoViewportPercentage;
use values::HasViewportPercentage;

impl NoViewportPercentage for SpecifiedValue {}
no_viewport_percentage!(SpecifiedValue);

#[derive(Copy, Clone, Debug, Eq, PartialEq)]
#[cfg_attr(feature = "servo", derive(HeapSizeOf, Deserialize, Serialize))]
Expand Down

0 comments on commit abc40f6

Please sign in to comment.