Skip to content

Commit

Permalink
Implement max-width, min-width for BlockFlow.
Browse files Browse the repository at this point in the history
  • Loading branch information
ILyoan committed Nov 7, 2013
1 parent d73fc68 commit ce6a3ec
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 8 deletions.
33 changes: 29 additions & 4 deletions src/components/main/layout/block.rs
Expand Up @@ -9,7 +9,7 @@ use layout::context::LayoutContext;
use layout::display_list_builder::{DisplayListBuilder, ExtraDisplayListData};
use layout::flow::{BlockFlowClass, FlowClass, FlowContext, FlowData, ImmutableFlowUtils};
use layout::flow;
use layout::model::{MaybeAuto, Specified, Auto};
use layout::model::{MaybeAuto, Specified, Auto, specified_or_none, specified};
use layout::float_context::{FloatContext, Invalid};

use std::cell::Cell;
Expand Down Expand Up @@ -391,16 +391,41 @@ impl FlowContext for BlockFlow {
let margin_bottom = MaybeAuto::from_style(style.Margin.margin_bottom,
remaining_width).specified_or_zero();

let (width, margin_left, margin_right) =
let (width, maybe_margin_left, maybe_margin_right) =
(MaybeAuto::from_style(style.Box.width, remaining_width),
MaybeAuto::from_style(style.Margin.margin_left, remaining_width),
MaybeAuto::from_style(style.Margin.margin_right, remaining_width));

let (width, margin_left, margin_right) = self.compute_horiz(width,
margin_left,
margin_right,
maybe_margin_left,
maybe_margin_right,
available_width);

// If the tentative used width is greater than 'max-width', width should be recalculated,
// but this time using the computed value of 'max-width' as the computed value for 'width'.
let (width, margin_left, margin_right) = {
match specified_or_none(style.Box.max_width, remaining_width) {
Some(value) if value < width => self.compute_horiz(Specified(value),
maybe_margin_left,
maybe_margin_right,
available_width),
_ => (width, margin_left, margin_right)
}
};
// If the resulting width is smaller than 'min-width', width should be recalculated,
// but this time using the value of 'min-width' as the computed value for 'width'.
let (width, margin_left, margin_right) = {
let computed_min_width = specified(style.Box.min_width, remaining_width);
if computed_min_width > width {
self.compute_horiz(Specified(computed_min_width),
maybe_margin_left,
maybe_margin_right,
available_width)
} else {
(width, margin_left, margin_right)
}
};

model.margin.top = margin_top;
model.margin.right = margin_right;
model.margin.bottom = margin_bottom;
Expand Down
20 changes: 16 additions & 4 deletions src/components/main/layout/model.rs
Expand Up @@ -104,9 +104,21 @@ impl BoxModel {
}

pub fn compute_padding_length(&self, padding: computed::LengthOrPercentage, content_box_width: Au) -> Au {
match padding {
computed::LP_Length(length) => length,
computed::LP_Percentage(p) => content_box_width.scale_by(p)
}
specified(padding, content_box_width)
}
}

pub fn specified_or_none(length: computed::LengthOrPercentageOrNone, containing_length: Au) -> Option<Au> {
match length {
computed::LPN_None => None,
computed::LPN_Percentage(percent) => Some(containing_length.scale_by(percent)),
computed::LPN_Length(length) => Some(length),
}
}

pub fn specified(length: computed::LengthOrPercentage, containing_length: Au) -> Au {
match length {
computed::LP_Length(length) => length,
computed::LP_Percentage(p) => containing_length.scale_by(p)
}
}

5 comments on commit ce6a3ec

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from ILyoan, metajack
at ILyoan@ce6a3ec

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging ILyoan/servo/max_width = ce6a3ec into auto

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ILyoan/servo/max_width = ce6a3ec merged ok, testing candidate = 651b2f0

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 651b2f0

Please sign in to comment.