Skip to content

Commit

Permalink
Add test for Profiler::get_statistics, and remove empty space around …
Browse files Browse the repository at this point in the history
…Profiler::get_statistics.

Profiler::get_statistics calculates mean, median, min, and max for a given vector of data. This commit adds a test for the calculated statistics.
  • Loading branch information
jeenalee committed Jul 7, 2016
1 parent 6230911 commit d47b769
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 3 deletions.
4 changes: 1 addition & 3 deletions components/profile/time.rs
Expand Up @@ -327,8 +327,7 @@ impl Profiler {
true
}


fn get_statistics(data: &[f64]) -> (f64, f64, f64, f64) {
pub fn get_statistics(data: &[f64]) -> (f64, f64, f64, f64) {
let data_len = data.len();
let (mean, median, min, max) =
(data.iter().sum::<f64>() / (data_len as f64),
Expand All @@ -338,7 +337,6 @@ impl Profiler {
(mean, median, min, max)
}


fn print_buckets(&mut self) {
match self.output {
Some(OutputOptions::FileName(ref filename)) => {
Expand Down
21 changes: 21 additions & 0 deletions tests/unit/profile/time.rs
Expand Up @@ -15,3 +15,24 @@ fn time_profiler_smoke_test() {
chan.send(ProfilerMsg::Exit(ipcchan));
assert!(true, "Can tell the profiler thread to exit");
}

#[test]
fn time_profilers_stats_test() {
let even_data = vec![1.234, 3.24567, 3.54578, 5.0, 5.324, 7.345, \
9.2345, 10.2342345, 13.2599, 15.0];
let (even_mean, even_median, even_min, even_max) = time::Profiler::get_statistics(&even_data);

assert_eq!(7.34230845, even_mean);
assert_eq!(7.345, even_median);
assert_eq!(1.234, even_min);
assert_eq!(15.0, even_max);

let odd_data = vec![1.234, 3.24567, 3.54578, 5.0, 5.324, 7.345, \
9.2345, 10.2342345, 13.2599];
let (odd_mean, odd_median, odd_min, odd_max) = time::Profiler::get_statistics(&odd_data);

assert_eq!(6.491453833333334, odd_mean);
assert_eq!(5.324, odd_median);
assert_eq!(1.234, odd_min);
assert_eq!(13.2599, odd_max);
}

0 comments on commit d47b769

Please sign in to comment.