Skip to content

Commit

Permalink
style: Remove Valgrind workaround to make ::slotted use the rule hash.
Browse files Browse the repository at this point in the history
Bug: 1426516
Reviewed-by: emilio
MozReview-Commit-ID: 2q14kHjajIr
  • Loading branch information
emilio committed Apr 28, 2018
1 parent b5c18c2 commit e5878b9
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions components/style/selector_map.rs
Expand Up @@ -454,13 +454,7 @@ fn specific_bucket_for<'a>(component: &'a Component<SelectorImpl>) -> Bucket<'a>
//
// So inserting `span` in the rule hash makes sense since we want to
// match the slotted <span>.
//
// FIXME(emilio, bug 1426516): The line below causes valgrind failures
// and it's probably a false positive, we should uncomment whenever
// jseward is back to confirm / whitelist it.
//
// Meanwhile taking the code path below is slower, but still correct.
// Component::Slotted(ref selector) => find_bucket(selector.iter()),
Component::Slotted(ref selector) => find_bucket(selector.iter()),
Component::Host(Some(ref selector)) => find_bucket(selector.iter()),
_ => Bucket::Universal,
}
Expand Down

0 comments on commit e5878b9

Please sign in to comment.