Remove extra hash-map lookup unregistering media controls

servo · Jul 22, 2019 · f8ae394 · f8ae394
1 parent 5aba6d5
commit f8ae394
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/components/script/dom/document.rs b/components/script/dom/document.rs
@@ -2475,15 +2475,15 @@ impl Document {
     }
 
     pub fn unregister_media_controls(&self, id: &str) {
-        if let Some(media_controls) = self.media_controls.borrow().get(id) {
+        if let Some(ref media_controls) = self.media_controls.borrow_mut().remove(id) {
+            let media_controls = DomRoot::from_ref(&**media_controls);
             media_controls.Host().detach_shadow();
             media_controls
                 .upcast::<Node>()
                 .dirty(NodeDamage::OtherNodeDamage);
         } else {
             debug_assert!(false, "Trying to unregister unknown media controls");
         }
-        self.media_controls.borrow_mut().remove(id);
     }
 }