Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the form owner concept #15938

Merged
merged 1 commit into from Mar 15, 2017
Merged

Implement the form owner concept #15938

merged 1 commit into from Mar 15, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented Mar 14, 2017 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/htmlselectelement.rs, components/script/dom/document.rs, components/script/dom/htmllegendelement.rs, components/script/dom/element.rs, components/script/dom/htmlfieldsetelement.rs, components/script/dom/servoparser/html.rs, components/script/dom/virtualmethods.rs, components/script/dom/htmlobjectelement.rs, components/script/dom/htmllabelelement.rs, components/script/dom/htmltextareaelement.rs, components/script/dom/htmloutputelement.rs, components/script/dom/htmlimageelement.rs, components/script/dom/htmlinputelement.rs, components/script/dom/htmlbuttonelement.rs, components/script/dom/node.rs, components/script/dom/htmlformelement.rs
  • @KiChjang: components/script/dom/htmlselectelement.rs, components/script/dom/document.rs, components/script/dom/htmllegendelement.rs, components/script/dom/element.rs, components/script/dom/htmlfieldsetelement.rs, components/script/dom/servoparser/html.rs, components/script/dom/virtualmethods.rs, components/script/dom/htmlobjectelement.rs, components/script/dom/htmllabelelement.rs, components/script/dom/htmltextareaelement.rs, components/script/dom/htmloutputelement.rs, components/script/dom/htmlimageelement.rs, components/script/dom/htmlinputelement.rs, components/script/dom/htmlbuttonelement.rs, components/script/dom/node.rs, components/script/dom/htmlformelement.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 14, 2017
@nox
Copy link
Contributor Author

nox commented Mar 14, 2017

@bors-servo try

bors-servo pushed a commit that referenced this pull request Mar 14, 2017
Auto merge of #15938 - servo:form-owner, r=<try>
9ab5384 
Implement the form owner concept
@bors-servo
Copy link
Contributor

⌛ Trying commit 06d7438 with merge 9ab5384...

@nox nox mentioned this pull request Mar 14, 2017
Closed
4 tasks
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Mar 14, 2017
@nox
Copy link
Contributor Author

nox commented Mar 14, 2017 

  ▶ Unexpected subtest result in /html/semantics/forms/form-control-infrastructure/form_owner_and_table.html:
  │ FAIL [expected PASS] Form element and form controls nested inside a table are correctly handled
  │   → assert_equals: input1's form owner must not have changed since they are both in the same subtree expected Element node <form id="form2"></form> but got null
  │ 
  │ @http://web-platform.test:8000/html/semantics/forms/form-control-infrastructure/form_owner_and_table.html:40:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1409:20
  │ test@http://web-platform.test:8000/resources/testharness.js:501:9
  └ @http://web-platform.test:8000/html/semantics/forms/form-control-infrastructure/form_owner_and_table.html:21:7

  ▶ CRASH [expected OK] /html/semantics/forms/the-label-element/labelable-elements.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  │ 3.3 (Core Profile) Mesa 12.0.1
  │ Element must be a form control (thread ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(1) }, at /checkout/src/libcore/option.rs:785)
  │ stack backtrace:
  │    0:     0x7f501bf9020d - backtrace::backtrace::trace::hce6a3819d897a887
  │    1:     0x7f501bf906f2 - backtrace::capture::Backtrace::new::hb5a725a088a2a2fc
  │    2:     0x7f501b950133 - servo::main::{{closure}}::h9d96b5c32a8afffa
  │    3:     0x7f501d77912d - std::panicking::rust_panic_with_hook
  │                         at /checkout/src/libstd/panicking.rs:550
  │    4:     0x7f501d778fc4 - std::panicking::begin_panic<collections::string::String>
  │                         at /checkout/src/libstd/panicking.rs:511
  │    5:     0x7f501d778ef9 - std::panicking::begin_panic_fmt
  │                         at /checkout/src/libstd/panicking.rs:495
  │    6:     0x7f501d778e87 - std::panicking::rust_begin_panic
  │                         at /checkout/src/libstd/panicking.rs:471
  │    7:     0x7f501d7a5eed - core::panicking::panic_fmt
  │                         at /checkout/src/libcore/panicking.rs:69
  │    8:     0x7f501d7a5f7d - core::option::expect_failed
  │                         at /checkout/src/libcore/option.rs:785
  │    9:     0x7f501c4dec31 - <script::dom::htmllabelelement::HTMLLabelElement as script::dom::htmlformelement::FormControl>::form_owner::h9e772c9d57e0befa
  │   10:     0x7f501c4b47aa - script::dom::htmlformelement::FormControl::reset_form_owner::h1080b8175412728e
  │   11:     0x7f501c46b6bd - <script::dom::element::Element as script::dom::virtualmethods::VirtualMethods>::bind_to_tree::hfbd91ae0a263451b
  │   12:     0x7f501c57b18c - script::dom::virtualmethods::VirtualMethods::bind_to_tree::h2698c535994f77e9
  │   13:     0x7f501c51ce33 - script::dom::node::Node::insert::h10778b9390129365
  │   14:     0x7f501c51c1ec - script::dom::node::Node::pre_insert::ha9ca0faa71a57e23
  │   15:     0x7f501c563305 - script::dom::servoparser::insert::h8a74af9f0aeef3a7
  │   16:     0x7f501c0873a1 - <html5ever::tree_builder::TreeBuilder<Handle, Sink> as html5ever::tree_builder::actions::TreeBuilderActions<Handle>>::insert_element::he8f2c6f8417d1c15
  │   17:     0x7f501c06da7f - <html5ever::tree_builder::TreeBuilder<Handle, Sink> as html5ever::tree_builder::rules::TreeBuilderStep<Handle>>::step::hcdfac00b0f99b1b5
  │   18:     0x7f501c041cb6 - <html5ever::tree_builder::TreeBuilder<Handle, Sink> as html5ever::tokenizer::interface::TokenSink>::process_token::hda795badd2678fd8
  │   19:     0x7f501c2a9e2f - <html5ever::tokenizer::Tokenizer<Sink>>::process_token::h850be6dd60c79e1f
  │   20:     0x7f501c2aa53d - <html5ever::tokenizer::Tokenizer<Sink>>::emit_current_tag::hf834290a35a74013
  │   21:     0x7f501c2b19a7 - <html5ever::tokenizer::Tokenizer<Sink>>::step::he6df318c2b9452f6
  │   22:     0x7f501c2ac6cf - <html5ever::tokenizer::Tokenizer<Sink>>::run::h5725b6881259c55f
  │   23:     0x7f501c55b1d0 - script::dom::servoparser::Tokenizer::feed::h180171964611c029
  │   24:     0x7f501c55a9ed - script::dom::servoparser::ServoParser::do_parse_sync::h2676270b9bff96b9
  │   25:     0x7f501c55a69c - script::dom::servoparser::ServoParser::parse_sync::h4a7419b789141155
  │   26:     0x7f501c558aa2 - script::dom::servoparser::ServoParser::resume_with_pending_parsing_blocking_script::h1e46d0971745712a
  │   27:     0x7f501c431a53 - script::dom::document::Document::process_pending_parsing_blocking_script::h9162a653c43d6b47
  │   28:     0x7f501c431679 - script::dom::document::Document::pending_parsing_blocking_script_loaded::h79bae47bcd68824f
  │   29:     0x7f501c4eebad - <script::dom::htmlscriptelement::ScriptContext as net_traits::FetchResponseListener>::process_response_eof::h339164ad544bb687
  │   30:     0x7f501c5e889a - <script::network_listener::ListenerRunnable<A, Listener> as script::script_thread::Runnable>::handler::hf78496d3b9b1c759
  │   31:     0x7f501c5ee9ef - <script::script_thread::CancellableRunnable<T> as script::script_thread::Runnable>::handler::hb3401df4e966854a
  │   32:     0x7f501c608945 - script::script_thread::ScriptThread::handle_msg_from_script::h4fb921a02f36cead
  │   33:     0x7f501c600f0c - script::script_thread::ScriptThread::handle_msgs::{{closure}}::h95a96e772221ddd7
  │   34:     0x7f501c5fc1da - script::script_thread::ScriptThread::handle_msgs::hb7c261538c9b5201
  │   35:     0x7f501c5f6b47 - script::script_thread::ScriptThread::start::hb46c4910de904afb
  │   36:     0x7f501c1a1164 - std::panicking::try::do_call::ha18c2fc1e2f674e1
  │   37:     0x7f501d78014a - panic_unwind::__rust_maybe_catch_panic
  │                         at /checkout/src/libpanic_unwind/lib.rs:98
  │   38:     0x7f501c2a58e7 - <F as alloc::boxed::FnBox<A>>::call_box::h667d881caee9bfc3
  │   39:     0x7f501d777d14 - alloc::boxed::{{impl}}::call_once<(),()>
  │                         at /checkout/src/liballoc/boxed.rs:650
  │                          - std::sys_common::thread::start_thread
  │                         at /checkout/src/libstd/sys_common/thread.rs:21
  │                          - std::sys::imp::thread::{{impl}}::new::thread_start
  │                         at /checkout/src/libstd/sys/unix/thread.rs:84
  │   40:     0x7f501981e183 - start_thread
  │   41:     0x7f501933537c - clone
  │   42:                0x0 - <unknown>
  │ ERROR:servo: Element must be a form control
  └ Pipeline failed in hard-fail mode.  Crashing!

@nox nox added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. S-tests-failed The changes caused existing tests to fail. labels Mar 14, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Mar 14, 2017
@nox
Copy link
Contributor Author

nox commented Mar 15, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 72c472b with merge b641275...

bors-servo pushed a commit that referenced this pull request Mar 15, 2017
Auto merge of #15938 - servo:form-owner, r=<try>
b641275 
Implement the form owner concept

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15938)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Mar 15, 2017
@jdm
Copy link
Member

jdm commented Mar 15, 2017 

  ▶ Unexpected subtest result in /html/semantics/forms/form-control-infrastructure/form_owner_and_table.html:
  │ FAIL [expected PASS] Form element and form controls nested inside a table are correctly handled
  │   → assert_equals: input1's form owner must not have changed since they are both in the same subtree expected Element node <form id="form2"></form> but got null
  │ 
  │ @http://web-platform.test:8000/html/semantics/forms/form-control-infrastructure/form_owner_and_table.html:40:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1409:20
  │ test@http://web-platform.test:8000/resources/testharness.js:501:9
  └ @http://web-platform.test:8000/html/semantics/forms/form-control-infrastructure/form_owner_and_table.html:21:7

@nox nox assigned jdm and unassigned asajeffrey Mar 15, 2017
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Mar 15, 2017
@nox
Copy link
Contributor Author

nox commented Mar 15, 2017

@bors-servo r=nox,jdm

@bors-servo
Copy link
Contributor

📌 Commit 38a6171 has been approved by nox,jdm

@highfive highfive assigned nox and unassigned jdm Mar 15, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 15, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 38a6171 with merge ed98cb9...

bors-servo pushed a commit that referenced this pull request Mar 15, 2017
Auto merge of #15938 - servo:form-owner, r=nox,jdm
ed98cb9 
Implement the form owner concept

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15938)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: nox,jdm
Pushing ed98cb9 to master...

@bors-servo bors-servo merged commit 38a6171 into master Mar 15, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 15, 2017
This was referenced Mar 15, 2017
Closed
Merged
@emilio emilio deleted the form-owner branch March 15, 2017 17:13
jdm pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 17, 2017
@mukilan @jdm
Implement the form owner concept
4a77219 
Upstreamed from servo/servo#15938 [ci skip]
@jdm jdm mentioned this pull request Apr 17, 2017
Merged
@nox nox mentioned this pull request Sep 30, 2017
Closed
@tigercosmos tigercosmos mentioned this pull request Aug 23, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nox @highfive @bors-servo @jdm @asajeffrey @mukilan