Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly parse background-size in background longhand (fixes #15199) #16513

Merged
merged 1 commit into from Apr 20, 2017
Merged

Properly parse background-size in background longhand (fixes #15199) #16513

merged 1 commit into from Apr 20, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented Apr 18, 2017 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/background.mako.rs
  • @emilio: components/style/properties/longhand/background.mako.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 18, 2017
@nox
Copy link
Contributor Author

nox commented Apr 18, 2017

r? @upsuper

@highfive highfive assigned upsuper and unassigned emilio Apr 18, 2017
@upsuper
Copy link
Contributor

upsuper commented Apr 18, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit af1c026 has been approved by upsuper

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 18, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit af1c026 with merge 28473e1...

bors-servo pushed a commit that referenced this pull request Apr 18, 2017
Auto merge of #16513 - nox:background-slash-size, r=upsuper
28473e1 
Properly parse background-size in background longhand (fixes #15199)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16513)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 18, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 18, 2017
@nox
Copy link
Contributor Author

nox commented Apr 18, 2017

@bors-servo r=upsuper

@bors-servo
Copy link
Contributor

📌 Commit 589fbff has been approved by upsuper

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 18, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 589fbff with merge 97ce3ae...

bors-servo pushed a commit that referenced this pull request Apr 18, 2017
Auto merge of #16513 - nox:background-slash-size, r=upsuper
97ce3ae 
Properly parse background-size in background longhand (fixes #15199)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16513)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 18, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 20, 2017
@nox
Copy link
Contributor Author

nox commented Apr 20, 2017

@bors-servo r=upsuper

@bors-servo
Copy link
Contributor

📌 Commit efdc67d has been approved by upsuper

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 20, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit efdc67d with merge 26fd659...

bors-servo pushed a commit that referenced this pull request Apr 20, 2017
Auto merge of #16513 - nox:background-slash-size, r=upsuper
26fd659 
Properly parse background-size in background longhand (fixes #15199)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16513)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: upsuper
Pushing 26fd659 to master...

@bors-servo bors-servo merged commit efdc67d into servo:master Apr 20, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@upsuper upsuper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nox @highfive @upsuper @bors-servo @emilio