Allow border radii to be set via preshints #16800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
highfive
added
the
S-awaiting-review
|
Might be worth converting https://github.com/Manishearth/servo/blob/195e37954f6921e78fc9e7acdca2baa749e11778/ports/geckolib/glue.rs#L1458 into a panic now that we support all preshints |
|
r? @emilio |
|
@bors-servo r+ Yeah, converting it into a panic as a followup sounds good to me. |
|
📌 Commit 195e379 has been approved by |
highfive
added
S-awaiting-merge
|
It's one line, I'll just make it a panic here itself |
highfive
added
S-awaiting-review
|
@bors-servo r+ |
|
📌 Commit 97ff764 has been approved by |
highfive
added
S-awaiting-merge
Manishearth
force-pushed
the
border-radius
branch
from
97ff764
to
d1c3021
Compare
highfive
added
S-awaiting-review
|
@bors-servo r=emilio |
|
📌 Commit d1c3021 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
May 11, 2017
Allow border radii to be set via preshints Fixes rendering of `<hr>` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16800) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 11, 2017
servo/servo#16800 MozReview-Commit-ID: AmbCWZ6z0vf
aethanyc
pushed a commit
to aethanyc/gecko-dev
that referenced
this pull request
May 12, 2017
servo/servo#16800 MozReview-Commit-ID: AmbCWZ6z0vf
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
servo/servo#16800 MozReview-Commit-ID: AmbCWZ6z0vf UltraBlame original commit: e956dc8d6b1dafb84f426addd9c1859abfbd5a99
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
servo/servo#16800 MozReview-Commit-ID: AmbCWZ6z0vf UltraBlame original commit: e956dc8d6b1dafb84f426addd9c1859abfbd5a99
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
servo/servo#16800 MozReview-Commit-ID: AmbCWZ6z0vf UltraBlame original commit: e956dc8d6b1dafb84f426addd9c1859abfbd5a99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rendering of
<hr>This change is