Replace initial about:blank on navigation #16848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highfive
added
the
S-awaiting-review
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
May 12, 2017
Replace initial about:blank on navigation <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14720 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
💔 Test failed - linux-dev |
cbrewster
force-pushed
the
replace_initial_about_blank
branch
from
a6f7117
to
dce09a1
Compare
|
LGTM. Squash, update the manifest, and r=me. |
Add test for initial about:blank replacement
cbrewster
force-pushed
the
replace_initial_about_blank
branch
from
dce09a1
to
d357783
Compare
|
@bors-servo r=asajeffrey |
|
📌 Commit d357783 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
May 17, 2017
…ffrey Replace initial about:blank on navigation <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14720 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16848) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-wpt |
highfive
added
S-tests-failed
|
|
☔ The latest upstream changes (presumably #16916) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@asajeffrey I wonder if the issues here have to do with subtle differences between normal navigations and navigations with replacement enabled... Consider the case where a navigation occurs with replacement enabled:
Should we be sending two Navigating with replacement enabled also changes the timing of when the I'm currently digging into our replacement navigation logic, but I wanted to know if you had any ideas. |
|
I wonder if we should not be using 1: https://html.spec.whatwg.org/multipage/browsers.html#update-the-session-history-with-the-new-page Step 2.2 |
|
Hmm, I see what you mean. We shouldn't be sending two |
|
🔒 Merge conflict |
4 similar comments
|
🔒 Merge conflict |
|
🔒 Merge conflict |
|
🔒 Merge conflict |
|
🔒 Merge conflict |
|
@bors-servo: r- |
|
Closing until I have time to work on this again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is