Clear webrender image id when resizing a canvas. #17278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asajeffrey
added
A-content/canvas
highfive
added
the
S-awaiting-review
emilio
approved these changes
Jun 12, 2017
| // Webrender doesn't let images change size, so we clear the webrender image key. | ||
| if let Some(image_key) = self.image_key.take() { | ||
| self.webrender_api.delete_image(image_key); | ||
| } |
There was a problem hiding this comment.
r=me, but could you do the same in the webgl_paint_thread? Right now the readback path suffers the same problem afaict.
There was a problem hiding this comment.
(Or filing an issue is fine too)
asajeffrey
force-pushed
the
canvas-clear-webrender-image-key-when-resizing
branch
from
bfece4b
to
4e04daa
Compare
|
@bors-servo r=emilio |
|
📌 Commit 4e04daa has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jun 13, 2017
…en-resizing, r=emilio Clear webrender image id when resizing a canvas. <!-- Please describe your changes on the following line: --> Webrender isn't very happy if images change size, so clear the webrender image key when resizing a canvas. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17277 - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17278) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webrender isn't very happy if images change size, so clear the webrender image key when resizing a canvas.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is