Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Debug implementations. #17298

Merged
merged 1 commit into from Jun 13, 2017
Merged

Added Debug implementations. #17298

merged 1 commit into from Jun 13, 2017

Conversation

asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jun 13, 2017 •
edited by larsbergstrom

Added enough Debug implementations to be able to debug script thread message processing.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because we don't test debugging

This change is Reviewable

@asajeffrey asajeffrey added the A-content/script Related to the script thread label Jun 13, 2017
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/task_source/user_interaction.rs, components/script/script_thread.rs, components/script/script_runtime.rs, components/script/task_source/dom_manipulation.rs, components/script_traits/lib.rs and 1 more
  • @KiChjang: components/net_traits/image/base.rs, components/net_traits/image/base.rs, components/script/task_source/user_interaction.rs, components/net_traits/image_cache.rs, components/net_traits/image_cache.rs and 5 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 13, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@mbrubeck
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit a47e94c has been approved by mbrubeck

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 13, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit a47e94c with merge 6db2354...

bors-servo pushed a commit that referenced this pull request Jun 13, 2017
Auto merge of #17298 - asajeffrey:script-more-debug-impls, r=mbrubeck
6db2354 
Added Debug implementations.

<!-- Please describe your changes on the following line: -->

Added enough `Debug` implementations to be able to debug script thread message processing.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because we don't test debugging

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17298)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: mbrubeck
Pushing 6db2354 to master...

@bors-servo bors-servo merged commit a47e94c into servo:master Jun 13, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
A-content/script Related to the script thread
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asajeffrey @highfive @mbrubeck @bors-servo