Add AudioListener/AudioPanner DOM interfaces #21502

Manishearth · 2018-08-23T22:06:26Z

Seems to work.

I'll need some changes to the servo-media side to support the panner
node getters as well as the older setPosition()/etc APIs. I'll get to
those later.

r? @ferjm

This change is

highfive · 2018-08-23T22:06:30Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/mod.rs, components/script/dom/audioscheduledsourcenode.rs, components/script/dom/audiodestinationnode.rs, components/script/dom/audionode.rs, components/script/dom/webidls/AudioListener.webidl and 5 more
@KiChjang: components/script/dom/mod.rs, components/script/dom/audioscheduledsourcenode.rs, components/script/dom/audiodestinationnode.rs, components/script/dom/audionode.rs, components/script/dom/webidls/AudioListener.webidl and 5 more

highfive · 2018-08-23T22:06:32Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

Manishearth · 2018-08-23T22:28:07Z

Tested, the following example works:

<script type="text/javascript">
let ctx = new AudioContext();
let osc = ctx.createOscillator();
let panner = new PannerNode(ctx, {"coneOuterAngle": 0, "positionX": 100, "positionY": 0, "positionZ": 100, "refDistance": 100, "rolloffFactor": 0.01});
osc.connect(panner);
panner.connect(ctx.destination);
osc.start();
panner.positionX.linearRampToValueAtTime(-100, 0.2);
panner.positionX.linearRampToValueAtTime(100, 0.2);
panner.positionX.linearRampToValueAtTime(-100, 0.4);
panner.positionX.linearRampToValueAtTime(-100, 0.4);
panner.positionX.linearRampToValueAtTime(100, 0.6);
panner.positionX.linearRampToValueAtTime(-100, 0.6);
panner.positionX.linearRampToValueAtTime(100, 0.8);
panner.positionX.linearRampToValueAtTime(100, 0.8);
panner.positionX.linearRampToValueAtTime(-100, 1.0);
panner.positionX.linearRampToValueAtTime(100, 1.0);
panner.positionX.linearRampToValueAtTime(-100, 1.2);
panner.positionX.linearRampToValueAtTime(-100, 1.2);
panner.positionX.linearRampToValueAtTime(100, 1.4);
panner.positionX.linearRampToValueAtTime(-100, 1.4);
panner.positionX.linearRampToValueAtTime(100, 1.6);
panner.positionX.linearRampToValueAtTime(100, 1.6);
</script>

(should I check this in to tests/html?)

Manishearth · 2018-08-23T22:33:16Z

@bors-servo try=wpt

bors-servo · 2018-08-23T22:33:21Z

⌛ Trying commit c62216d with merge 3dd46ec...

@ferjm

Add AudioListener/AudioPanner DOM interfaces Seems to work. I'll need some changes to the servo-media side to support the panner node getters as well as the older `setPosition()`/etc APIs. I'll get to those later. r? @ferjm  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21502)

bors-servo · 2018-08-23T22:53:04Z

💔 Test failed - linux-rel-css

ferjm

Looks good!

We need to add the channelCount and channelCountMode constraints for PannerNode.

Likewise, even though we do not support HRTF yet, we should also add the autiomationRate constraints for PannerNode and AudioListener AudioParams.

Thanks!

ferjm · 2018-08-24T05:30:54Z

components/script/dom/audiolistener.rs

+            window,
+            context,
+            node,
+            ParamType::Position(ParamDir::Y),


This should be ParamDir::Z

ferjm · 2018-08-24T05:31:34Z

components/script/dom/audiolistener.rs

+            window,
+            context,
+            node,
+            ParamType::Forward(ParamDir::Y),


ParamDir::Z

ferjm · 2018-08-24T05:31:48Z

components/script/dom/audiolistener.rs

+            window,
+            context,
+            node,
+            ParamType::Up(ParamDir::Y),


ParamDir::Z

ferjm · 2018-08-24T05:35:28Z

components/script/dom/baseaudiocontext.rs

@@ -297,6 +304,15 @@ impl BaseAudioContextMethods for BaseAudioContext {
        })
    }

+    /// https://webaudio.github.io/web-audio-api/#dom-baseaudiocontext-destination


Change link to https://webaudio.github.io/web-audio-api/#dom-baseaudiocontext-listener, please

Manishearth · 2018-08-24T15:35:40Z

We don't have autiomationrate constraints, the automationrate is simply ignored (this code already exists in the media crate)

Manishearth · 2018-08-24T15:35:49Z

@bors-servo try=wpt

bors-servo · 2018-08-24T15:35:55Z

⌛ Trying commit e7ed310 with merge 7196cdf...

@ferjm

Add AudioListener/AudioPanner DOM interfaces Seems to work. I'll need some changes to the servo-media side to support the panner node getters as well as the older `setPosition()`/etc APIs. I'll get to those later. r? @ferjm  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21502)

Manishearth · 2018-08-24T15:39:15Z

This should cause a bunch of new WPT failures since previously some tests didn't fully run at all, but that's okay.

At some point we need to switch gears to WPT and whittle those down, most of them aren't much work.

bors-servo · 2018-08-24T15:40:00Z

💔 Test failed - linux-rel-css

Manishearth · 2018-08-24T21:31:53Z

@bors-servo r=ferjm

bors-servo · 2018-08-24T21:31:53Z

📌 Commit 25332f0 has been approved by ferjm

bors-servo · 2018-08-24T22:44:18Z

⌛ Testing commit 25332f0 with merge e793d94...

@ferjm

Add AudioListener/AudioPanner DOM interfaces Seems to work. I'll need some changes to the servo-media side to support the panner node getters as well as the older `setPosition()`/etc APIs. I'll get to those later. r? @ferjm  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21502)

bors-servo · 2018-08-24T23:02:54Z

💔 Test failed - linux-dev

Manishearth · 2018-08-24T23:13:01Z

@bors-servo r=ferjm

needed to run update-manifest because I changed interfaces.html

bors-servo · 2018-08-24T23:13:01Z

📌 Commit 04e60e6 has been approved by ferjm

bors-servo · 2018-08-24T23:13:07Z

⌛ Testing commit 04e60e6 with merge d827370...

@ferjm

Add AudioListener/AudioPanner DOM interfaces Seems to work. I'll need some changes to the servo-media side to support the panner node getters as well as the older `setPosition()`/etc APIs. I'll get to those later. r? @ferjm  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21502)

bors-servo · 2018-08-25T00:00:45Z

💔 Test failed - mac-rel-wpt1

Manishearth · 2018-08-25T00:05:09Z

@bors-servo retry

{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "document.open should throw an InvalidStateError with XML document even when there is an active parser executing script", "test": "/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-xml.window.html", "line": 48140, "action": "test_result", "expected": "FAIL"}

seems intermittent, let's find out

bors-servo · 2018-08-25T00:05:12Z

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...

bors-servo · 2018-08-25T00:50:40Z

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: ferjm
Pushing d827370 to master...

Upgrade to latest servo-media

4b48cfa

highfive assigned ferjm Aug 23, 2018

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 23, 2018

Manishearth force-pushed the listener branch 2 times, most recently from 35b8104 to 9a52aac Compare August 23, 2018 22:13

highfive added the S-tests-failed The changes caused existing tests to fail. label Aug 23, 2018

ferjm reviewed Aug 24, 2018

View reviewed changes

jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 24, 2018

Add AudioListener DOM interface

9228ca3

Manishearth force-pushed the listener branch from c62216d to e7ed310 Compare August 24, 2018 15:33

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Aug 24, 2018

highfive added the S-tests-failed The changes caused existing tests to fail. label Aug 24, 2018

Manishearth force-pushed the listener branch from e7ed310 to b30642a Compare August 24, 2018 15:50

highfive removed the S-tests-failed The changes caused existing tests to fail. label Aug 24, 2018

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 24, 2018

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 24, 2018

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 24, 2018

Update WPT expectations

04e60e6

Manishearth force-pushed the listener branch from 25332f0 to 04e60e6 Compare August 24, 2018 23:12

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 24, 2018

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 24, 2018

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 25, 2018

bors-servo merged commit 04e60e6 into servo:master Aug 25, 2018

bors-servo mentioned this pull request Aug 25, 2018

Fix some WebAudio WPTs #21506

Merged

3 tasks

ferjm added this to Done in WebAudio Nov 29, 2018

Manishearth deleted the listener branch May 7, 2019 22:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AudioListener/AudioPanner DOM interfaces #21502

Add AudioListener/AudioPanner DOM interfaces #21502

Manishearth commented Aug 23, 2018 •

edited by SimonSapin

highfive commented Aug 23, 2018

highfive commented Aug 23, 2018

Manishearth commented Aug 23, 2018

Manishearth commented Aug 23, 2018

bors-servo commented Aug 23, 2018

bors-servo commented Aug 23, 2018

ferjm left a comment •

edited

ferjm Aug 24, 2018

ferjm Aug 24, 2018

ferjm Aug 24, 2018

ferjm Aug 24, 2018

Manishearth commented Aug 24, 2018

Manishearth commented Aug 24, 2018

bors-servo commented Aug 24, 2018

Manishearth commented Aug 24, 2018

bors-servo commented Aug 24, 2018

Manishearth commented Aug 24, 2018

bors-servo commented Aug 24, 2018

bors-servo commented Aug 24, 2018

bors-servo commented Aug 24, 2018

Manishearth commented Aug 24, 2018

bors-servo commented Aug 24, 2018

bors-servo commented Aug 24, 2018

bors-servo commented Aug 25, 2018

Manishearth commented Aug 25, 2018

bors-servo commented Aug 25, 2018

bors-servo commented Aug 25, 2018

Add AudioListener/AudioPanner DOM interfaces #21502

Add AudioListener/AudioPanner DOM interfaces #21502

Conversation

Manishearth commented Aug 23, 2018 • edited by SimonSapin

highfive commented Aug 23, 2018

highfive commented Aug 23, 2018

Manishearth commented Aug 23, 2018

Manishearth commented Aug 23, 2018

bors-servo commented Aug 23, 2018

bors-servo commented Aug 23, 2018

ferjm left a comment • edited

Choose a reason for hiding this comment

ferjm Aug 24, 2018

Choose a reason for hiding this comment

ferjm Aug 24, 2018

Choose a reason for hiding this comment

ferjm Aug 24, 2018

Choose a reason for hiding this comment

ferjm Aug 24, 2018

Choose a reason for hiding this comment

Manishearth commented Aug 24, 2018

Manishearth commented Aug 24, 2018

bors-servo commented Aug 24, 2018

Manishearth commented Aug 24, 2018

bors-servo commented Aug 24, 2018

Manishearth commented Aug 24, 2018

bors-servo commented Aug 24, 2018

bors-servo commented Aug 24, 2018

bors-servo commented Aug 24, 2018

Manishearth commented Aug 24, 2018

bors-servo commented Aug 24, 2018

bors-servo commented Aug 24, 2018

bors-servo commented Aug 25, 2018

Manishearth commented Aug 25, 2018

bors-servo commented Aug 25, 2018

bors-servo commented Aug 25, 2018

Manishearth commented Aug 23, 2018 •

edited by SimonSapin

ferjm left a comment •

edited