Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP-cache refresh bug #26999

Closed
wants to merge 1 commit into from

Conversation

gterzian
Copy link
Member

FIX #24385

following up on #24388


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 20, 2020
@servo-wpt-sync
Copy link
Collaborator

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24263.

@gterzian gterzian changed the title fetch/http-cache: add test for 304 select resource for update failure Fix HTTP-cache refersh bug Jun 20, 2020
@servo-wpt-sync
Copy link
Collaborator

PR title changed; changed existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24263.

@gterzian gterzian changed the title Fix HTTP-cache refersh bug Fix HTTP-cache refresh bug Jun 20, 2020
@servo-wpt-sync
Copy link
Collaborator

PR title changed; changed existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#24263.

@gterzian gterzian marked this pull request as draft June 20, 2020 10:18
@gterzian
Copy link
Member Author

Doesn't seem necessary anymore. See whatwg/fetch#950

@gterzian gterzian closed this Jun 25, 2020
@gterzian gterzian deleted the fix_cache_revalidationwq branch June 25, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-awaiting-review There is new code that needs to be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reload goes back in time (http cache issue?)
4 participants