New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M1503: Extend the developer tools support - Initial steps #5229
Conversation
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon. |
Critic review: https://critic.hoppipolla.co.uk/r/4276 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This is the initial step of the student project for extending developer tools support as mentioned here: https://github.com/servo/servo/wiki/More-developer-tools-student-project |
@hsvalava This looks great! Have you tested it to make sure it works as expected? |
Thanks for the proof :) I've left one comment on the Critic tool; be sure to click the 'sign in' link there so you get future updates by email. |
Great! Could you squash your commits together now? |
Hi Josh, |
Yep, it's one of the few times that force pushing is encouraged :) |
Done :) |
Fixing ConsoleMsg for console.log messages in the Developer Tools web console.
Some test (./mach test-wpt --processes 4) failed. |
Grumble. That's a new intermittent failure that we haven't figured out. |
Fixing ConsoleMsg for console.log messages in the Developer Tools web console.
Thanks Josh! :) |
Fixing ConsoleMsg for console.log messages in the Developer Tools web console.