Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M1503: Extend the developer tools support - Initial steps #5229

Merged
merged 1 commit into from Mar 20, 2015

Conversation

hsvalava
Copy link
Contributor

Fixing ConsoleMsg for console.log messages in the Developer Tools web console.

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4276

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@hsvalava
Copy link
Contributor Author

This is the initial step of the student project for extending developer tools support as mentioned here: https://github.com/servo/servo/wiki/More-developer-tools-student-project

@jdm jdm added the S-awaiting-review There is new code that needs to be reviewed. label Mar 16, 2015
@jdm
Copy link
Member

jdm commented Mar 16, 2015

@hsvalava This looks great! Have you tested it to make sure it works as expected?

@hsvalava
Copy link
Contributor Author

Hi Josh,
I tested console.log from the Firefox console, and it works (screenshot attached). The message is printed, and the file name and line number are dummy values for now.
servo_console_log

@jdm
Copy link
Member

jdm commented Mar 16, 2015

Thanks for the proof :) I've left one comment on the Critic tool; be sure to click the 'sign in' link there so you get future updates by email.

@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 16, 2015
@jdm
Copy link
Member

jdm commented Mar 19, 2015

Great! Could you squash your commits together now?

@jdm jdm added S-needs-squash Some (or all) of the commits in the PR should be combined. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Mar 19, 2015
@hsvalava
Copy link
Contributor Author

Hi Josh,
I squashed my commits together (git rebase -i --autosquash /master) but the push is getting rejected (non-fast forward updates). Am I supposed to force push the changes?

@jdm
Copy link
Member

jdm commented Mar 19, 2015

Yep, it's one of the few times that force pushing is encouraged :)

@hsvalava
Copy link
Contributor Author

Done :)

@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-needs-squash Some (or all) of the commits in the PR should be combined. labels Mar 19, 2015
bors-servo pushed a commit that referenced this pull request Mar 19, 2015
Fixing ConsoleMsg for console.log messages in the Developer Tools web console.
@hsvalava
Copy link
Contributor Author

Some test (./mach test-wpt --processes 4) failed.
Looks like it's run out of memory, or is it something else?
(pid:3754) "ERROR:net::image::base: stb_image failed: stbi_load_from_memory failed"
OSError: [Errno 12] Cannot allocate memory

@jdm
Copy link
Member

jdm commented Mar 20, 2015

Grumble. That's a new intermittent failure that we haven't figured out.

bors-servo pushed a commit that referenced this pull request Mar 20, 2015
Fixing ConsoleMsg for console.log messages in the Developer Tools web console.
@bors-servo bors-servo closed this Mar 20, 2015
@bors-servo bors-servo merged commit 3830d8e into servo:master Mar 20, 2015
@hsvalava
Copy link
Contributor Author

Thanks Josh! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants