feat: forward cli args #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OBannon37
commented
Feb 27, 2022
| @@ -18,6 +24,7 @@ if (argv && psConfig) { | |||
| logLevel: argv.logLevel, | |||
| prefix: argv.prefix, | |||
| scripts: argv.scripts, | |||
| args: postCommandFlags, | |||
There was a problem hiding this comment.
another alternative to this new flag would be to just concatenate all the args as space separated strings to argv._[0].
It would be the same functionality either way, since we can run a maximum of one script from the cli now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Follows the format specified in #139 to forward command line arguments to scripts. Notably, this disables running scripts in parallel from the command line.
Why:
See discussion in #139
How:
By changing the parsing of command line args in src/bin/nps.js.
Checklist:
I'd like to confirm the approach here. Specifically, I'm not sure if we should also be considering programatic use here. I thought no: I left the implementation of
runPackageScriptas is, so folks can still run scripts in parallel from the function call if they'd like to. I am assuming if someone is calling that function, they can already pass arbitrary command line args to each command just with string concatenation after a space, which is not possible from the CLI using the previous yargs parsing.This would be a breaking change if released.
If the approach looks good, I can add documentation.