Tweaks to docs + wrap long lines + add function index #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1269 1274 +5
=========================================
+ Hits 1269 1274 +5
|
olivroy
changed the title
9 tasks
|
@olivroy, I just merged your other PR into |
|
I will fetch locally to redocument |
…t is the norm in tidyverse packages
olivroy
commented
Dec 7, 2023
olivroy
commented
Dec 7, 2023
billdenney
reviewed
Dec 7, 2023
|
thanks for the review! I addressed your comments |
|
@sfirke, this looks good to me. Are you good with merging it? |
olivroy
changed the title
sfirke
reviewed
Jan 25, 2024
| # If no NA in 3rd variable, it doesn't appear in split list | ||
| expect_equal(length(dplyr::starwars %>% | ||
| dplyr::filter(species == "Human") %>% | ||
| tabyl(eye_color, skin_color, gender, show_missing_levels = TRUE)), 2) | ||
|
|
||
| # The starwars data set changed in dplyr v 1.0.0 so have two blocks of tests: |
|
This is great, thanks @olivroy and thanks also @billdenney for the review and questions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few minor edits to the docs of deprecated functions. Adding hyperlinks to the new functions.
Ref: https://roxygen2.r-lib.org/articles/rd-formatting.html?q=link#function-links
Edit: I added a few more tweaks to docs to ensure that long lines are wrapped, links are present.
Edit2: since this PR mostly makes changes to docs, you may want to take a look at the .Rd diffs.