馃敡 Allow disabling the src/seq/v index
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes #94 - Follows on from share/sharedb#657 This change is to work alongside upstream work to remove ShareDB's usage of `getCommittedOpVersion()`. In `sharedb-mongo` this function requires an entire extra op index, just to handle a corner case where two `create` ops are submitted at the same time, which should happen relatively infrequently. This change allows consumers to opt out of individual indexes. For example, if we're not using `getCommittedOpVersion()`, consumers can opt out of the automatic `src`/`seq`/`v` index creation with: ```js new ShareDbMongo( mongoUrl, { disableIndexCreation: { src_seq_v: true, }, }, ); ``` Note that if this index already exists, consumers will need to manually remove it. Previous behaviour will still work, so setting: ```js new ShareDbMongo( mongoUrl, { disableIndexCreation: true, }, ); ``` disables **all** index creation.
ericyhwang
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db.getCommittedOpVersion()聽sharedb#657This change is to work alongside upstream work to remove ShareDB's usage of
getCommittedOpVersion().In
sharedb-mongothis function requires an entire extra op index, just to handle a corner case where twocreateops are submitted at the same time, which should happen relatively infrequently.This change allows consumers to opt out of individual indexes. For example, if we're not using
getCommittedOpVersion(), consumers can opt out of the automaticsrc/seq/vindex creation with:Note that if this index already exists, consumers will need to manually remove it.
Previous behaviour will still work, so setting:
disables all index creation.