Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Youtube to work again #1563

Merged
merged 1 commit into from Oct 17, 2022
Merged

Conversation

mrsofiane
Copy link

There was a missing letter in the url to look for the username, after that a cookie was needed to bypass the google agreements.

@mrsofiane
Copy link
Author

mrsofiane commented Oct 17, 2022

This PR fix #1202 , added Youtube channel and Youtube User, a cookie is added to by pass the google privacy agreement.

@sdushantha
Copy link
Member

Great find! Does this cookie expire at some point?

@mrsofiane
Copy link
Author

@sdushantha I dont think so, i found it in a StackOverflow answer since 2021, https://stackoverflow.com/questions/67198673/bypass-cookie-agreement-page-while-web-scraping-using-python

@P3nt3st3r123
Copy link

P3nt3st3r123 commented Oct 17, 2022

Base on uBlockOrigin issues: uBlockOrigin/uAssets#7842
image

@mrsofiane
Copy link
Author

@P3nt3st3r123 yes it' exactly what i added in this PR to bypass the google agreement popup

Copy link
Member

@sdushantha sdushantha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🥳

@sdushantha sdushantha merged commit fdc1659 into sherlock-project:master Oct 17, 2022
@mrsofiane
Copy link
Author

@sdushantha Could you add the hacktoberfest label please ? thank you

@sdushantha
Copy link
Member

@mrsofiane done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants