Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shopinvader_search_engine: ease override of depends for category compute #1527

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

shopinvader_search_engine: ease override of depends for category compute #1527

wants to merge 1 commit into from

Conversation

cyrilmanuel
Copy link

@cyrilmanuel cyrilmanuel commented Apr 5, 2024 •
edited

ease override of depends for category compute to be override by other category fields.

@simahawk
Copy link
Contributor

simahawk commented Apr 5, 2024

Not a "fix" 😉 Also, can you please remove the odoo version from the commit?
Should be something like shopinvader_search_engine: ease override of depends for category compute

@cyrilmanuel cyrilmanuel changed the title [16.0] shopinvader_search_engine: fix compute_shopinvader_category shopinvader_search_engine: ease override of depends for category compute Apr 5, 2024
simahawk
simahawk approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@cyrilmanuel
Copy link
Author

hii @lmignon can you merge this PR ?

@sebastienbeau sebastienbeau added this to the 16.0 milestone Jun 3, 2024
@cyrilmanuel
Copy link
Author

hi @lmignon i think we have 50 50. can we merge it to go ahead please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@lmignon lmignon lmignon requested changes

@sebastienbeau sebastienbeau sebastienbeau left review comments

@AnizR AnizR AnizR left review comments

@benwillig benwillig benwillig approved these changes

@santostelmo santostelmo santostelmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cyrilmanuel @simahawk @shopinvader-git-bot @lmignon @sebastienbeau @benwillig @AnizR @santostelmo