fix #648 & replace deprecated methods #652
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuzijun
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Compatible with the historical version of IDE, do not change this API for now.
There was a problem hiding this comment.
pluginSinceBuild: 203.0
com.intellij.openapi.util.IconLoader#getIcon(java.lang.String, java.lang.Class<?>) already exists in version 202.8194.7 and it is not marked @ deprecated in version 223.
Of course, you can also use IntelliJ Plugin Verifier to verify compatibility. (I have verified its compatibility in my plugin (V) (°,,,,°) (V))
There was a problem hiding this comment.
I have modified this API in a certain version, but the display effect is not as expected. I am not sure which version of the IDE has been fixed. 😟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NAVIGATOR_TABS_PANEL_DISPOSABLE_MAP.put(id, this);before getUser()?com.intellij.openapi.util.IconLoader#getIcon(java.lang.String, java.lang.Class<?>)instead.