Update usb.c to address Bug 1886 ("sr: usb: Failed to get libusb file descriptors.") on Windows #235
Conversation
Add Windows handling to usb.c. Per https://libusb.sourceforge.io/api-1.0/group__libusb__poll.html libusb_get_pollfds() As file descriptors are a Unix-specific concept, this function is not available on Windows and will always return NULL.
|
Thank you! This fix worked for me (with Kingst LA1010). I imagine this is causing issues with everything on Windows, so it would be nice to see merged, building from source is a lot of effort. |
|
Same here... neither the Saleae Clone nor the Kingst LA5016 did work with pulseview on windows, with the very same error I am surprised that it was rather difficult to find more with this error, tried a few nightly builds I found on my drives from a few month ago.. same and on various workstations/laptops. Building pulseview myself with this fix (MXE) solved the problem. Thanks for this elegant fix! |
There was a problem hiding this comment.
This patch solved my problem. Built with MXE using your average WSL2 Ubuntu 22.04 install.
If you intend to do the same, note that:
- In addition to all the listed
sigrok-utilreqs and theMXEreqs, you will also need to install at leastdoxygenandasciidoctor. mxe_fixes.patchandlibusb1_upgrade.patchdon't appear to be necessary anymore
|
Would be nice if this fix merged to main. I am currently stuck on my Windows machine to use the HiLetgo USB Logic Analyzer |
Me too... |
|
Looking forward to have this merged into a release as well. |
|
Anybody got a windows binary? Maybe attach on a release in the fork etc? |
|
Would love to find one too. Meanwhile I started using https://www.saleae.com/downloads/ which works with my USB logic analyzer as well. |
|
Would be nice to have this merged into main. |
Add Windows handling to usb.c.
Per https://libusb.sourceforge.io/api-1.0/group__libusb__poll.html
libusb_get_pollfds()
As file descriptors are a Unix-specific concept, this function is not available on Windows and will always return NULL.