Support numbers as input for sha1 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Else attempting `1 OP_SHA1` in the IDE will get stuck and yield `Uncaught TypeError: msg.utf8Encode is not a function`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the change attempting
1 OP_SHA1in the IDE will get stuck and yieldUncaught TypeError: msg.utf8Encode is not a functionin the consoleThe String conversion was taken from
Sha256.hashwhich works finebitcoinIDE/build/script_interpreter/sha256.js
Line 28 in 1cac29c
Thanks a bunch for the project 馃憤