New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember resources 7 #687
base: master
Are you sure you want to change the base?
Ember resources 7 #687
Conversation
Fixes #686 I had a PR as well but it would not let me submit it. @simonihmig could we get this workflow run please. This is blocking me from updating ember concurrency V4 as ember-resources 6.x has a peer-dependency on ember-concurrency 3.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working in this! LGTM, happy to merge once green. There seems to be a minor linting error though.
lint issues resolved |
uhg. lots of errors suddenly. I don't have time to dive into these atm... |
Did some experimentation. The first CI works which appears to be using ember 4.0 (and @types/ember_application 4.0.7). When trying other versions of ember, @types/ember_application 4.0.11 is being used which is where the errors are being generated. Appears to be mis-matched typescript types I guess. Hoping the little research I did helps, but very new to typescript and this is beyond my ability. |
Anyone able to take a look at this? It seems to be a problem of the types dependencies and not actually the code changes. |
Sorry atm no time to dive in
|
Anyone have any chance in the foreseeable future? Have multiple addons that can not be updated as a result of this as addons are moving on to require ember-resources V7. |
following these instructions I abstracted the class based resources of e-r 6 to those of ember-resource 7.
NullVoxPopuli/ember-resources#1056
It works in the sense that all tests pass