Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-resources to 7.0.0 #688

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bgantzler
Copy link

This is the bare minimum to get to ember-resources 7.0.0 following the migration guide.

While the one by basz is better (does not require the migrated addon provided by nullvoxpopuli) that PR has stalled. Hoping that this one will not have the same issues.

@bgantzler
Copy link
Author

@simonihmig if you were able to kick off the workflow and see if this has the same issues are the other PR would be appreciated

@simonihmig
Copy link
Owner

Done! Thanks for looking into this!

@bgantzler
Copy link
Author

Will update the PR. I have been getting this

Property 'controller' must be of type 'Registry', but here has type 'Registry'.

In my own code, there must be a update to the linter. This code is exactly like it is in the blueprints but throwing this error. Everywhere I have saw it it was suggested to disable the linter for those lines.

If anyone knows a better solution please let me know

@cah-brian-gantzler
Copy link
Contributor

This seems to be a problem with the dependencies on definitively typed types. When the --no-lockfile option is used in the yarn install, this error occurs. Something has been updated in the definitely typed types that is incorrect. This error also occurs on the master branch.

The error is occurring when the following command is running glint --declaration.

Is it possible to not do the ember-try senarios temporarily until this is fixed? Or perhaps skip the glint declarations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants