Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request rate limit (exceeding 2 calls in a second) using Shopify Tap #124

Open
ytsrc opened this issue Oct 13, 2021 · 1 comment
Open

Request rate limit (exceeding 2 calls in a second) using Shopify Tap #124

ytsrc opened this issue Oct 13, 2021 · 1 comment

Comments

@ytsrc
Copy link

ytsrc commented Oct 13, 2021

I am trying to figure out where the configuration is to limit the rate within the tap, however, i couldnt find it. I see a separate python file in Shopify git (requests_rate_limit.py) which seems to throttle API requests, but i do not see that file in the tap configuration within my server when i installed the tap . Below is the error i s
Screen Shot 2021-10-02 at 4 44 18 PM
Screen Shot 2021-10-02 at 4 39 15 PM
Screen Shot 2021-10-02 at 4 39 04 PM
ee

@dmosorast
Copy link
Contributor

Hello @YtCodeBase, you are correct that the rate limiting is handled by the Shopify Python SDK, so you will not find any rate limiting code in this tap.

Looking at your screenshots, I see that the line referenced in the second screenshot has a line number that does not match up with the latest code found in this repository. The screenshot shows that code appearing on line 166, whereas the latest tap has that code on line 219. I'm not sure at a glance what has changed in between, nor which version you are running, but I would recommend updating to the latest version of tap-shopify to see if it handles the rate limit better.

If not, then the maintainers and/or changelog of the Python Shopify SDK might be able shed some light on what is happening. I don't have time to check right now, but if you would like to debug your scenario, I would look towards upgrading that version here in a local copy of the tap's code to see if it helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants