Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update compat #36

Merged
merged 1 commit into from
Nov 10, 2023
Merged

update compat #36

merged 1 commit into from
Nov 10, 2023

Conversation

nignatiadis
Copy link
Contributor

Hi!

The main purpose of this pull request is to update the StatsBase compat (currently it is not possible to simultaneously install Discretizers and the latest StatsBase.

I also added a compat entry for Statistics, as per https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (600faf0) 94.06% compared to head (28c1dee) 94.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   94.06%   94.28%   +0.22%     
==========================================
  Files          10       11       +1     
  Lines         893      945      +52     
==========================================
+ Hits          840      891      +51     
- Misses         53       54       +1     
Flag Coverage Δ
unittests 94.28% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mykelk mykelk merged commit 9b7026a into sisl:master Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants