Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Add tests and basic ci qs #23

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

mficzel
Copy link
Member

@mficzel mficzel commented Oct 27, 2023

Add code linting, static analysis and basic tests

Also the following is fixed:

@mficzel mficzel force-pushed the task/addTestsAndAdjustService branch from d558dc9 to 8b0799b Compare October 27, 2023 16:37
Alongside the supported versions were adjusted to Neos 8 with php 8
@mficzel mficzel force-pushed the task/addTestsAndAdjustService branch from 8b0799b to 991157b Compare October 27, 2023 16:41
@mficzel mficzel force-pushed the task/addTestsAndAdjustService branch from 1aecbf2 to d263f43 Compare October 27, 2023 17:23
@mficzel mficzel requested a review from jonnitto October 27, 2023 17:27
Copy link
Collaborator

@jonnitto jonnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works as expected

@jonnitto jonnitto merged commit 88bde49 into main Feb 8, 2024
3 checks passed
@jonnitto jonnitto deleted the task/addTestsAndAdjustService branch February 8, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text encoding problem Future of this Idea
2 participants