Fixed|ServerApp: Managing World audiences at shutdown (ShellUsers)

ShellUsers was trying to remove its World observer after World had already been destroyed.
skyjake · Jul 23, 2013 · 16ded53 · 16ded53
1 parent d79d8ad
commit 16ded53
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/doomsday/server/src/serversystem.cpp b/doomsday/server/src/serversystem.cpp
@@ -89,6 +89,9 @@ DENG2_PIMPL(ServerSystem)
 
         // Update the beacon with the new port.
         beacon.start(port);
+
+        App_World().audienceForMapChange += shellUsers;
+
         return true;
     }
 
@@ -104,6 +107,8 @@ DENG2_PIMPL(ServerSystem)
 
     void deinit()
     {
+        App_World().audienceForMapChange -= shellUsers;
+
         beacon.stop();
 
         // Close the listening socket.

diff --git a/doomsday/server/src/shellusers.cpp b/doomsday/server/src/shellusers.cpp
@@ -42,8 +42,6 @@ DENG2_PIMPL_NOREF(ShellUsers)
 
 ShellUsers::ShellUsers() : d(new Instance)
 {
-    App_World().audienceForMapChange += this;
-
     // Player information is sent periodically to all shell users.
     connect(d->infoTimer, SIGNAL(timeout()), this, SLOT(sendPlayerInfoToAll()));
     d->infoTimer->start();
@@ -53,8 +51,6 @@ ShellUsers::~ShellUsers()
 {
     d->infoTimer->stop();
 
-    App_World().audienceForMapChange -= this;
-
     foreach(ShellUser *user, d->users)
     {
         delete user;