Fixed|Scripting|libcore: Memory leak when removing dictionary elements

skyjake · Jan 23, 2017 · 24d38da · 24d38da
1 parent f0aaeb2
commit 24d38da
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/doomsday/sdk/libcore/src/data/dictionaryvalue.cpp b/doomsday/sdk/libcore/src/data/dictionaryvalue.cpp
@@ -277,8 +277,7 @@ void DictionaryValue::subtract(Value const &subtrahend)
         throw KeyError("DictionaryValue::subtract",
             "Key '" + subtrahend.asText() + "' does not exist in the dictionary");
     }
-    delete i->second;
-    _elements.erase(i);
+    remove(i);
 }
 
 void DictionaryValue::operator >> (Writer &to) const
@@ -315,4 +314,4 @@ void DictionaryValue::operator << (Reader &from)
     }
 }
 
-} // namespace de
+} // namespace de
diff --git a/doomsday/tests/test_script/main.cpp b/doomsday/tests/test_script/main.cpp
@@ -37,6 +37,9 @@ int main(int argc, char **argv)
 #if 0
         Script testScript("def returnValue(a): return a\n"
                           "returnValue(True) and returnValue(True)\n");
+#endif
+#if 0
+        Script testScript("print 'Dictionary:', {'a':'A', 'b':'B'} - 'a'\n");
 #endif
         Process proc(testScript);
         LOG_MSG("Script parsing is complete! Executing...");