Windows|Cygwin: Return type warnings should be errors

skyjake · Sep 1, 2019 · 2d21c17 · 2d21c17
1 parent 626a247
commit 2d21c17
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/doomsday/cmake/PlatformCygwin.cmake b/doomsday/cmake/PlatformCygwin.cmake
@@ -16,3 +16,7 @@ add_definitions (
     -D_GNU_SOURCE=1
     -DDE_PLATFORM_ID="win-${DE_ARCH}"
 )
+
+if (CMAKE_COMPILER_IS_GNUCXX)
+    append_unique (CMAKE_CXX_FLAGS -Werror=return-type)
+endif ()
diff --git a/doomsday/libs/gloom/src/render/light.cpp b/doomsday/libs/gloom/src/render/light.cpp
@@ -170,6 +170,7 @@ Mat4f Light::lightMatrix(gfx::CubeFace face) const
     case gfx::NegativeZ:
         return proj * Mat4f::lookAt(pos + Vec3f(0, 0, 1), pos, Vec3f(0, 1, 0));
     }
+    return {};
 }
 
 } // namespace gloom
diff --git a/doomsday/tools/shell/src/folderselection.cpp b/doomsday/tools/shell/src/folderselection.cpp
@@ -101,6 +101,7 @@ void FolderSelection::setEnabled(bool yes)
 de::NativePath FolderSelection::path() const
 {
 //    return convert(d->edit->text());
+    return {};
 }
 
 void FolderSelection::selectFolder()