Fixed bug #2641111: "Win32: Crash when launching with Shareware Doom"…

… - caused by Material patch definitions for DOOMII confusing the material manager into trying to create new materials from incomplete definitions (a better mechanism for this is needed).

doomsday/engine/portable/src/con_busy.c

@@ -92,7 +92,7 @@ static DGLuint texScreenshot; // Captured screenshot of the latest frame.
  * @return              Return value of the worker.
  */
 int Con_Busy(int flags, const char* taskName, busyworkerfunc_t worker,
-             void *workerData)
+             void* workerData)
 {
     int                 result = 0;
 
@@ -113,7 +113,7 @@ int Con_Busy(int flags, const char* taskName, busyworkerfunc_t worker,
     {   // Take a copy of the task name.
         size_t              len = strlen(taskName);
 
-        busyTaskName = M_Calloc(len);
+        busyTaskName = M_Calloc(len + 1);
         snprintf(busyTaskName, len, "%s", taskName);
     }
     Sys_Unlock(busy_Mutex);

doomsday/engine/portable/src/p_materialmanager.c

@@ -529,10 +529,10 @@ Con_Message("P_MaterialCreate: Warning, attempted to create material "
      * A new material.
      */
 
-    // Sanity checks.
-    assert(tex != 0);
-    assert(width > 0);
-    assert(height > 0);
+    // Only create complete materials.
+    // \todo Doing this here isn't ideal.
+    if(tex == 0 || !(width > 0) || !(height > 0))
+        return NULL;
 
     mat = createMaterial(width, height, flags, mnamespace, def, tex);