Skip to content

Commit

Permalink
Fix typos and added a @todo re BSP tree element types
Browse files Browse the repository at this point in the history
  • Loading branch information
danij-deng committed Mar 12, 2013
1 parent ead11a1 commit 87eb710
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions doomsday/client/include/map/bspnode.h
Expand Up @@ -87,6 +87,10 @@ class Partition
* Node in the BSP tree. Children of a node can be either instances of BspNode
* or BspLeaf.
*
* @todo There is a missing abstraction here. BSP tree elements should be derived
* from a common base class, thereby enforcing which objects can be linked
* into the tree. -ds
*
* @ingroup map
*/
class BspNode : public de::MapElement
Expand All @@ -98,9 +102,10 @@ class BspNode : public de::MapElement
public: /// @todo make private:
Partition _partition;

/// Bounding box for each child.
/// Bounding box for each child subspace [Right, Left].
AABoxd _aaBox[2];

/// Child map elements [Right, Left].
de::MapElement *_children[2];

/// Unique. Set when saving the BSP.
Expand All @@ -117,7 +122,7 @@ class BspNode : public de::MapElement
~BspNode();

/**
* Returns the partition_t for the BSP node.
* Returns the Partition for the BSP node.
*/
Partition const &partition() const;

Expand Down Expand Up @@ -148,7 +153,7 @@ class BspNode : public de::MapElement
inline bool hasRight() const { return hasChild(RIGHT); }

/**
* Returns @c true iff a Light child element is configured for the BSP node.
* Returns @c true iff a Left child element is configured for the BSP node.
*/
inline bool hasLeft() const { return hasChild(LEFT); }

Expand Down

0 comments on commit 87eb710

Please sign in to comment.