Builder: XML feed omits <message> from commits if empty

skyjake · Dec 15, 2011 · 907c098 · 907c098
1 parent a08e0ad
commit 907c098
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/distrib/builder/changes.py b/distrib/builder/changes.py
@@ -136,7 +136,8 @@ def generate(self, format):
                 print >> out, '<repositoryUrl>%s</repositoryUrl>' % entry.link
                 print >> out, '<sha1>%s</sha1>' % entry.hash
                 print >> out, '<title>%s</title>' % entry.subject
-                print >> out, '<message>%s</message>' % entry.message
+                if len(entry.message):
+                    print >> out, '<message>%s</message>' % entry.message
                 print >> out, '</commit>'                
             print >> out, '</commits>'
             out.close()

diff --git a/distrib/builder/event.py b/distrib/builder/event.py
@@ -214,7 +214,7 @@ def html_description(self, encoded=True):
         if encoded: return '<![CDATA[' + msg + ']]>'    
         return msg
 
-    def xml_description():
+    def xml_description(self):
         msg = '<build>'
         msg += '<uniqueId>%i</uniqueId>' % self.number()
         msg += '<startDate>%s</startDate>' % self.text_timestamp()