Fixed|libdoomsday: Potential memory leak

Normally only one instance of Players is constructed, but since the players were constructed by the class, it should also delete them.
skyjake · Jun 11, 2016 · 92ca8d0 · 92ca8d0
1 parent 9e7a2be
commit 92ca8d0
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/doomsday/apps/libdoomsday/src/players.cpp b/doomsday/apps/libdoomsday/src/players.cpp
@@ -29,6 +29,15 @@ DENG2_PIMPL_NOREF(Players)
     {
         zap(players);
     }
+
+    ~Instance()
+    {
+        for (auto *plr : players)
+        {
+            delete plr;
+        }
+        zap(players);
+    }
 };
 
 Players::Players(Constructor playerConstructor) : d(new Instance)